[LU-4987] Issues introduced by LU-4107

• Status: Resolved
• Project: Lustre
• Fix Version/s: Lustre 2.6.0
• Type: Bug
• Priority: Critical
• Reporter: Christopher Morrone
• Assignee: Minh Diep
• Resolution: Fixed
• Severity: 3

Description

The patch from LU-4107, change 8033, introduced two bugs:

1) Duplicate stdio.h include
2) Changing user-space api based only on one's compiler.

I don't even understand why folks thought LUSTRE_ANONYMOUS_UNION_NAME was the right thing to do. The commenting is entirely inadequate here ("Fix anonymous union."), so I am not even sure what problem they were trying to fix. As far as I can tell, C++ has anonymous unions as well.

But regardless of the underlying problem, this does not seem like the solution we want. This makes the user-space API change based only one's choice of compiler. I don't think that is wise.

Comments

[Robert Read (Inactive)]

It looks like the duplicate stdio.h happened when the patch was rebased for patch set 5.
I also don't understand that define, and no one commented on it, either.

[Peter Jones]

Minh

Could you please comment?

Thanks

Peter

[Christopher Morrone]

I think I figured it out. Here are patches for both:

http://review.whamcloud.com/10175
http://review.whamcloud.com/10176

[Christopher Morrone]

Maloo reported failures on both patches. I am pretty doubtful that the failures were due to the patches. Please relaunch the tests (or let me know when to do a rebase when the problem is fixed).

[Christopher Morrone]

Someone restarted testing on http://review.whamcloud.com/10175 and that is now clear. http://review.whamcloud.com/10176 still needs testing relaunched.

[Jodi Levi (Inactive)]

Patches have landed to Master. Please reopen ticket if more work is needed.