[LU-5091] LU-4606 breaks --with-zfs-devel option

• Status: Resolved
• Project: Lustre
• Affects Version/s: Lustre 2.6.0
• Fix Version/s: Lustre 2.6.0
• Type: Bug
• Priority: Blocker
• Reporter: Brian Murrell (Inactive)
• Assignee: Nathaniel Clark
• Resolution: Fixed
• Severity: 3

Description

When LU-4606 landed it broke Lustre's --with-zfs-devel configure option which was previously landed in LU-3497.

LU-4096 introduces a requirement to link userspace tools against libzfs and is not taking into account the path that --with-zfs-devel may be pointing to.

This landing, unfortunately passes testing on Toro but that is because Toro is masking this bug due to it having had libzfs installed as a system package on it's builders, which we want to avoid on Onyx.

This is because what is actually happening on Toro is that the Lustre build is getting it's headers from the path that --with-zfs-devel points to (which is the ZFS that was built at the same time as Lustre) but is linking against the library that is installed system-wide, which could be mis-matched.

Fortunately at this time, and on this branch they are at least API compatible but that could change on a different branch or as the ZFS API is updated and the system-installed zfs-devel stagnates.

This kind of divergence (between what is being built with Lustre and what is installed on the builders) and the masking of this bug is why zfs-devel should never have been installed as a system package on the builders and why we want to avoid it on Onyx.

Issue Links

• is duplicated by: LU-5096 Linker cannot find custom libzfs loca...
• is related to: LU-4606 Lustre hard codes libzfs.so.1 in lust...
• is related to: LU-5096 Linker cannot find custom libzfs loca...
• is related to: LU-5643 Flubbed merging of two patches in cha...

Comments

[James A Simmons]

Ran into this issue as well. To tired to make a patch right now tho.

[Nathaniel Clark]

http://review.whamcloud.com/10401

[Joshua Kugler (Inactive)]

Since all the builders currently have zfs RPMs installed on them, how do we test that this actually fixes the issue.

Oh...brian: if this builds on Onyx, then we're good, right?

[Brian Murrell (Inactive)]

joshua: Yep.

[Brian Murrell (Inactive)]

http://review.whamcloud.com/10401

utopiabound: Note that in the above patch, in lbuild you will need to arrange for the zfs RPM to be unpacked with rpm2cpio | cpio in addition to the existing unpacking of the zfs-devel RPM.

This is because the zfs-devel RPM doesn't contain any actual libraries but only contains the unversioned library symlinks pointing at the libraries that are installed with the zfs RPM.

[Brian Murrell (Inactive)]

Landed in b2659030edb7d34c91430ff924bab23881b6c230.