[LU-5123] lprocfs_write_frac_u64_helper does not respect multiplier Created: 30/May/14  Updated: 27/Aug/15  Resolved: 25/Jun/14

Status: Resolved
Project: Lustre
Component/s: None
Affects Version/s: Lustre 2.6.0
Fix Version/s: Lustre 2.6.0

Type: Bug Priority: Minor
Reporter: Stephen Champion Assignee: Emoly Liu
Resolution: Fixed Votes: 0
Labels: patch

Issue Links:
Related
Severity: 3
Rank (Obsolete): 14132

 Description   

Working on LU-4856, I have made use of lprocfs_write_frac_u64_helper, which turns out to not work. Specifically, the mult arg is ignored because of this logic:

units = 1;
if (units)
mult = mult < 0 ? -units : units;

This led to sanity 101a setting the 64 bit converted max_cached_mb to 32 pages (not mb) - which hung in a way that may be interesting in it's own right.

 Comments   
Comment by Stephen Champion [ 31/May/14 ]

http://review.whamcloud.com/#/c/10535/

Comment by Peter Jones [ 31/May/14 ]

Thanks Steve.

Emoly

Could you please help with this patch?

Thanks

Peter

Comment by Peter Jones [ 25/Jun/14 ]

Landed for 2.6

Generated at Sat Feb 10 01:48:43 UTC 2024 using Jira 9.4.14#940014-sha1:734e6822bbf0d45eff9af51f82432957f73aa32c.