[LU-5124] S_IF* constants are not bits Created: 30/May/14 Updated: 20/Jun/14 Resolved: 20/Jun/14 |
|
| Status: | Resolved |
| Project: | Lustre |
| Component/s: | None |
| Affects Version/s: | Lustre 2.6.0 |
| Fix Version/s: | Lustre 2.6.0 |
| Type: | Bug | Priority: | Minor |
| Reporter: | John Hammond | Assignee: | John Hammond |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | lod | ||
| Severity: | 3 |
| Rank (Obsolete): | 14139 |
| Description |
|
This is minor. In lod_load_striping_locked() we have tests: if (lu_object_attr(lod2lu_obj(lo)) & S_IFREG) {
...
} else if (lu_object_attr(lod2lu_obj(lo)) & S_IFDIR) {
...
This is wrong since in general the S_IF* constants are not single bits. |
| Comments |
| Comment by John Hammond [ 12/Jun/14 ] |
|
Please see http://review.whamcloud.com/10702. |
| Comment by Peter Jones [ 20/Jun/14 ] |
|
Landed for 2.6 |