[LU-515] gpdd-survey.sh/sgpdd-survey doesn't play nice with devices specified by alias

• Status: Resolved
• Project: Lustre
• Fix Version/s: Lustre 2.2.0
• Type: Bug
• Priority: Major
• Reporter: Wally Wang (Inactive)
• Assignee: Niu Yawei (Inactive)
• Resolution: Fixed
• Severity: 2

Description

For our acceptance-small configuration we specify devices by-id instead of device name since the
device name occasionally changes. This causes a problem with sgpdd-survey.sh since sgpdd-survey
doesn't translate the alias to the device name.

== test 1: sgpdd-survey, mds, scsidevs == 15:30:35 (1301603435)
Loading modules from
/opt/cray/lustre-cray_gem_s/1.8.4_2.6.32.27_0.2.2_1.0000.5785.16.1-1.0000.25970.22.205/lib64/lustre
lnet.debug=-1
lnet.subsystem_debug=0xffb7e3ff
lnet options: ' accept=all'
=== mds === nid00035 === /dev/disk/by-id/scsi-3600a0b80005121d800001f7a4cd16b41-part1 ===
nid00035: + rslt=/tmp/sgpdd_survey size=1024 crghi=2 thrhi=2
scsidevs="/dev/disk/by-id/scsi-3600a0b80005121d800001f7a4cd16b41-part1"
/opt/cray/lustre-cray_gem_s/1.8.4_2.6.32.27_0.2.2_1.0000.5785.16.1-1.0000.25970.22.205/bin/sgpdd-survey
nid00035: Can't find SG device for /dev/disk/by-id/scsi-3600a0b80005121d800001f7a4cd16b41-part1,
testing for partition
nid00035: Can't find SG device /dev/disk/by-id/scsi-3600a0b80005121d800001f7a4cd16b41-part.

It would be nice if either sgpdd-survey or sgpdd-survey.sh would translate aliases to device names.
The attached patch modifies sgpdd-survey to do a 'readlink -f' on the device name if the device
path is something like "/dev/disk/by-*" and the device path is a symbolic link (maybe this is
redundant?).

This is from Oracle bug 24487.

Comments

[Wally Wang (Inactive)]

The fix is in:

http://review.whamcloud.com/#change,1120

[Niu Yawei (Inactive)]

Hi, Wally

If you want the patch being landed on master, you should add the gate keeper Oleg as the reviewer.

I opened a ticket LU-608 to port this patch to b1_8 and master, looks it's duplicated with this one. Could you port this patch to b1_8 too? Thank you.

[Wally Wang (Inactive)]

For b1_8, please see:

http://review.whamcloud.com/#change,1284

[Peter Jones]

Niu

You are already handling LU610 which this is a duplicate of

Peter

[Build Master (Inactive)]

Integrated in lustre-master » x86_64,server,el5,ofa #300
LU-515 canonicalize the devices names

Oleg Drokin : f14d2b5feae5213ed243fb63702aa1eed7e0a8b1
Files :

• lustre-iokit/sgpdd-survey/sgpdd-survey

[Build Master (Inactive)]

Integrated in lustre-master » i686,client,el6,inkernel #300
LU-515 canonicalize the devices names

Oleg Drokin : f14d2b5feae5213ed243fb63702aa1eed7e0a8b1
Files :

• lustre-iokit/sgpdd-survey/sgpdd-survey

[Build Master (Inactive)]

Integrated in lustre-master » x86_64,server,el6,inkernel #300
LU-515 canonicalize the devices names

Oleg Drokin : f14d2b5feae5213ed243fb63702aa1eed7e0a8b1
Files :

• lustre-iokit/sgpdd-survey/sgpdd-survey

[Build Master (Inactive)]

Integrated in lustre-master » x86_64,client,el5,inkernel #300
LU-515 canonicalize the devices names

Oleg Drokin : f14d2b5feae5213ed243fb63702aa1eed7e0a8b1
Files :

• lustre-iokit/sgpdd-survey/sgpdd-survey

[Build Master (Inactive)]

Integrated in lustre-master » x86_64,client,el6,inkernel #300
LU-515 canonicalize the devices names

Oleg Drokin : f14d2b5feae5213ed243fb63702aa1eed7e0a8b1
Files :

• lustre-iokit/sgpdd-survey/sgpdd-survey

[Build Master (Inactive)]

Integrated in lustre-master » x86_64,client,ubuntu1004,inkernel #300
LU-515 canonicalize the devices names

Oleg Drokin : f14d2b5feae5213ed243fb63702aa1eed7e0a8b1
Files :

• lustre-iokit/sgpdd-survey/sgpdd-survey

[Build Master (Inactive)]

Integrated in lustre-master » x86_64,client,sles11,inkernel #300
LU-515 canonicalize the devices names

Oleg Drokin : f14d2b5feae5213ed243fb63702aa1eed7e0a8b1
Files :

• lustre-iokit/sgpdd-survey/sgpdd-survey

[Build Master (Inactive)]

Integrated in lustre-master » x86_64,client,el5,ofa #300
LU-515 canonicalize the devices names

Oleg Drokin : f14d2b5feae5213ed243fb63702aa1eed7e0a8b1
Files :

• lustre-iokit/sgpdd-survey/sgpdd-survey

[Build Master (Inactive)]

Integrated in lustre-master » i686,server,el5,inkernel #300
LU-515 canonicalize the devices names

Oleg Drokin : f14d2b5feae5213ed243fb63702aa1eed7e0a8b1
Files :

• lustre-iokit/sgpdd-survey/sgpdd-survey

[Build Master (Inactive)]

Integrated in lustre-master » i686,server,el6,inkernel #300
LU-515 canonicalize the devices names

Oleg Drokin : f14d2b5feae5213ed243fb63702aa1eed7e0a8b1
Files :

• lustre-iokit/sgpdd-survey/sgpdd-survey

[Build Master (Inactive)]

Integrated in lustre-master » i686,client,el5,ofa #300
LU-515 canonicalize the devices names

Oleg Drokin : f14d2b5feae5213ed243fb63702aa1eed7e0a8b1
Files :

• lustre-iokit/sgpdd-survey/sgpdd-survey

[Build Master (Inactive)]

Integrated in lustre-master » x86_64,server,el5,inkernel #300
LU-515 canonicalize the devices names

Oleg Drokin : f14d2b5feae5213ed243fb63702aa1eed7e0a8b1
Files :

• lustre-iokit/sgpdd-survey/sgpdd-survey

[Build Master (Inactive)]

Integrated in lustre-master » i686,server,el5,ofa #300
LU-515 canonicalize the devices names

Oleg Drokin : f14d2b5feae5213ed243fb63702aa1eed7e0a8b1
Files :

• lustre-iokit/sgpdd-survey/sgpdd-survey

[Build Master (Inactive)]

Integrated in lustre-master » i686,client,el5,inkernel #300
LU-515 canonicalize the devices names

Oleg Drokin : f14d2b5feae5213ed243fb63702aa1eed7e0a8b1
Files :

• lustre-iokit/sgpdd-survey/sgpdd-survey

[Niu Yawei (Inactive)]

landed to b1_8 and master.