[LU-5156] In osp_init_last_seq, the return value of osp_write_local_file is not being checked. Created: 06/Jun/14 Updated: 05/Jun/15 Resolved: 04/Dec/14 |
|
| Status: | Resolved |
| Project: | Lustre |
| Component/s: | None |
| Affects Version/s: | Lustre 2.6.0, Lustre 2.5.1, Lustre 2.4.3 |
| Fix Version/s: | Lustre 2.7.0 |
| Type: | Bug | Priority: | Minor |
| Reporter: | Di Wang | Assignee: | WC Triage |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Severity: | 3 |
| Rank (Obsolete): | 14224 |
| Description |
static int osp_init_last_seq(const struct lu_env *env, struct osp_device *osp)
{
............
rc = osp_write_local_file(env, osp, dto, &osi->osi_lb,
osi->osi_off);
<------------ check return value here.
}
}
|
| Comments |
| Comment by Andreas Dilger [ 06/Jun/14 ] |
|
This was introduced in commit v2_3_59_0-46-g6c4c51e, and the old code used to check the return code properly: rc = dt_record_write(env, m->opd_last_used_file, &osi->osi_lb,
&osi->osi_off, th);
dt_trans_stop(env, m->opd_storage, th);
if (rc)
GOTO(out, rc);
|
| Comment by Andreas Dilger [ 04/Dec/14 ] |
|
The error handling was fixed for 2.7.0 as part of |