[LU-5191] Parallel-scale has script error for ZFS

• Status: Resolved
• Project: Lustre
• Affects Version/s: Lustre 2.5.2
• Type: Bug
• Priority: Major
• Reporter: Cliff White (Inactive)
• Assignee: Cliff White (Inactive)
• Resolution: Fixed

Environment

Hyperion

• Severity: 3

Description

Appears to be a basic Bash error:
/usr/lib64/lustre/tests/parallel-scale.sh: line 138: [: missing `]'

Test returns garbage for summary (-nan) - not sure if the failure is related, as I shift to a different version of lustre/tests to complete my runs
Line is question is:
(code)
[ $(facet_fstype $SINGLEMDS) = zfs -o $(facet_fstype "ost1") = zfs] &&
SLOW=$ZFSSLOW

(code)

Comments

[Richard Henwood (Inactive)]

I notice: In the example above, there isn't a space after zfs and ']' (bash needs a space around square brackets) - in the script on master, there is:

http://git.whamcloud.com/?p=fs/lustre-release.git;a=blob;f=lustre/tests/parallel-scale.sh;h=af4ad5d1bc2fecf1253be2bae6cf306f7c98356c;hb=HEAD#138

[Cliff White (Inactive)]

This issue was already reported and fixed in 2013
http://git.whamcloud.com/?p=fs/lustre-release.git;a=commit;h=abd7b8c9e13681fd3baf463ccb9619f9bdf25e30

How did this miss 2.5 ? It appears that about half the commit is present in the 2.5.2 parallel-scale, the second portion of the commit is missing.

[Cliff White (Inactive)]

Fix here: http://review.whamcloud.com/10731