[LU-5275] clean up technical debt for proc_dir_entry changes

• Status: Resolved
• Project: Lustre
• Affects Version/s: Lustre 2.7.0
• Fix Version/s: Lustre 2.7.0
• Type: Bug
• Priority: Minor
• Reporter: Jodi Levi (Inactive)
• Assignee: John Hammond
• Resolution: Fixed
• Labels: patch
• Severity: 3

Description

This is to address the last comment made in LU-3319 to cleanup the technical debt.

Issue Links

• is related to: LU-5983 builds broken by LU-5275 fix
• is related to: LU-4416 support for 3.12 linux kernel
• is related to: LU-3319 Adapt to 3.10 upstream kernel proc_di...

Comments

[James A Simmons]

Can you link this to LU-4416.

[James A Simmons]

First of the patches

http://review.whamcloud.com/#/c/11451
http://review.whamcloud.com/#/c/11640

[Jodi Levi (Inactive)]

Patches landed to Master. Please reopen ticket if more is expected for this ticket.

[James A Simmons]

Sorry about the confusion but more patches are coming. Please reopen this ticket.

[Peter Jones]

Do you have a rough idea how many James?

[James A Simmons]

I say two, maybe three more patches.

[James A Simmons]

New cleanup patch at

http://review.whamcloud.com/#/c/12298

One patch left after this to cleanup lock handling that needs to be worked on.

[Jodi Levi (Inactive)]

James,
Are you planning to submit the patch for cleaning up lock handling for the 2.7 release?

[James A Simmons]

Yes I plan to update the second patch. The problem is the first patch is ready to land but it is based a earlier master revision. That current master has changed enough that I have to rebase the second patch I have after the first patch lands to master.

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch http://review.whamcloud.com/12298/
Subject: LU-5275 lprocfs: remove last of non seq data structs and functions.
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 0ad4f8a4227ed7dd93fec99d33c6bb25056473fc

[James A Simmons]

Update patch http://review.whamcloud.com/#/c/12235. This should be the last patch in the series.

[Gerrit Updater]

Johann Lombardi ([e-mail]) uploaded a new patch: http://review.whamcloud.com/12953
Subject: Revert "LU-5275 lprocfs: remove last of non seq data structs and functions."
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 80e25c90a3d45ee0ec55b0a83282168b0583303a

[Gerrit Updater]

Johann Lombardi ([e-mail]) merged in patch http://review.whamcloud.com/12953/
Subject: Revert "LU-5275 lprocfs: remove last of non seq data structs and functions."
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: b1e595c09e1b07a6840142b3ae015b8a5a8affeb

[Johann Lombardi (Inactive)]

For the record, i have reverted http://review.whamcloud.com/#/c/12298 since it broken the el6.6 build.

[Jodi Levi (Inactive)]

Patch landed to master.

[Gerrit Updater]

John L. Hammond ([e-mail]) uploaded a new patch: http://review.whamcloud.com/13225
Subject: LU-5275 lprocfs: reduce scope of params_tree.h
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: d4921339526c9076bf7a72660c86dac883b9eed4

[James A Simmons]

I have done exhaustive testing and looked very closely at the what states lustre procfs handling is in for the case of client and server being on the same node. I loaded lod then lov and vice versa as well as unload the modules in the two possible orders. I detected no leaks in either case. In order to fill out out proc trees we have to preform mounting/unmounting of the MDT and the client. I tried both orders of mounting and
umount and saw no issues with remove_proc_subtree. Tired various combos of mounting/unmounting and module loading/unloading. No memory leaks/disappearing directories or handling symlinks occurred. Please note this is all done on a 3.12 kernel. Also looking at detail of the procfs initialization and removal don't show a issue with remove_proc_subtree.

[Gerrit Updater]

John L. Hammond ([e-mail]) uploaded a new patch: http://review.whamcloud.com/13299
Subject: LU-5275 lprocfs: replace LPROCFS with CONFIG_PROC_FS
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 1cd9b42ae4bfa063ddeb1d9c153b86afb1373264

[Gerrit Updater]

James Simmons ([e-mail]) uploaded a new patch: http://review.whamcloud.com/13330
Subject: LU-5275 lprocfs: sync names to upstream kernel lustre client
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: a0ab151983e0655f95f7c5b53b09054b5159578a

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch http://review.whamcloud.com/13225/
Subject: LU-5275 lprocfs: reduce scope of params_tree.h
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: f9920b4924edce1bd341622eee4281fdcd41845a

[Gerrit Updater]

James Simmons ([e-mail]) uploaded a new patch: http://review.whamcloud.com/13341
Subject: LU-5275 libcfs: merge params_tree.h into lprocfs_status.h
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: b22696a65873fdb69caf2a652f3bfe266bfcb489

[James A Simmons]

Finally finished off the patch set thanks to John Hammond. The patches to finish this are:

http://review.whamcloud.com/#/c/13299
http://review.whamcloud.com/#/c/13341
http://review.whamcloud.com/#/c/12235
http://review.whamcloud.com/#/c/13330

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch http://review.whamcloud.com/13299/
Subject: LU-5275 lprocfs: replace LPROCFS with CONFIG_PROC_FS
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 7817e4c785d075aae76b635dcf799064590833b0

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch http://review.whamcloud.com/13341/
Subject: LU-5275 libcfs: merge params_tree.h into lprocfs_status.h
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 17d614c7017c41d3484b163c8d86d324335c93e0

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch http://review.whamcloud.com/12235/
Subject: LU-5275 lprocfs: remove all non-seq file functions
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: b66962c0f92b29353ac255400783e9b0faa9c2e3

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch http://review.whamcloud.com/13330/
Subject: LU-5275 lprocfs: sync names to upstream kernel lustre client
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: a172863af11bcef474191ca40eaa479179457c08

[Gerrit Updater]

John L. Hammond ([e-mail]) uploaded a new patch: http://review.whamcloud.com/13463
Subject: LU-5275 build: add LPROCFS to the deprecated symbol list
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: f0b41cec79d7b8f86387afb94820e8e507c2b21b

[Gerrit Updater]

James Simmons ([e-mail]) uploaded a new patch: http://review.whamcloud.com/13527
Subject: LU-5275 gnilnd: Add definition for PDE_DATA
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: d39d74651f6d0ee0a0f849ac558e243f03c52715

[James A Simmons]

Only two patches left

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch http://review.whamcloud.com/13463/
Subject: LU-5275 build: add LPROCFS to the deprecated symbol list
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 5639b66882d6e53e97ad2f799f8aba1efecce9e9

[James A Simmons]

Only one small one line patch to merge to finish this off. Ready for merger.

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch http://review.whamcloud.com/13527/
Subject: LU-5275 gnilnd: Add definition for PDE_DATA
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 1ede0cfcbaf021da493fcd4352f9d092e176a292

[Jodi Levi (Inactive)]

Patches landed to Master