[#LU-53] need to run autogen.sh if any debian patches touch a Makefile.am file

[LU-53] need to run autogen.sh if any debian patches touch a Makefile.am file Created: 24/Jan/11 Updated: 28/Feb/18 Resolved: 28/Feb/18
Status:	Resolved
Project:	Lustre
Component/s:	None
Affects Version/s:	Lustre 2.0.0, Lustre 1.8.6
Fix Version/s:	Lustre 2.1.0, Lustre 1.8.6

Type:

Bug

Priority:

Minor

Reporter:

Brian Murrell (Inactive)

Assignee:

Brian Murrell (Inactive)

Resolution:

Fixed

Votes:

Labels:

None

Severity:

Rank (Obsolete):

10110

Description

In the debian/rules file, we need to make sure that autogen.sh is run if any of the applied patches
touches a Makefile.am.

Comments

Comment by Build Master (Inactive) [ 08/Mar/11 ]

Integrated in reviews-centos5 #414
~~LU-53~~ run autogen if a Makefile.am is patched

Brian J. Murrell : d46754226fff9d21c2a0cee41c1a739600b95cfc
Files :

debian/rules

Comment by Brian Murrell (Inactive) [ 10/Mar/11 ]

Patrick, I've added you to this bug to reply to your gerrit comment:

From the debian pov this patch is okay, however I would prefer another distribution- independent solution for this scenario.

Given that this entire solution is about running autogen.sh in debian/rules files when it's determined to be necessary, I'm not sure I understand what you mean about a distribution-independent solution. Can you expand?

Comment by Build Master (Inactive) [ 10/Mar/11 ]

Integrated in reviews-centos5 #429
~~LU-53~~ run autogen if a Makefile.am is patched

Brian J. Murrell : 7b99ea6df830f597649d6f3d3767bf1f05cf1b92
Files :

debian/rules

Comment by Patrick Winnertz (Inactive) [ 10/Mar/11 ]

Yes, the current situation is running autogen.sh in debian/rules as the patches in debian/patches/* modifying some .am or .m4 files (or whatever files).

As also other distributions contain lustre, which may or may not currently also patch the source before building it would be prefereable to search for a solution for this bug which is not debian specific (which is currently the case for your patch).

A solution for every distribution whould be to do this check not in the distribution specific stuff (debian/rules, lustre.spec, or whatever), but in the makefiles or configure script directly so that autogen.sh is called automatically on every distribution if a .am, .m4, ... file is modified.

My suggestion would be to have a look on the modification date for e.g. the Makefile.am and the Makefile.in to see if Makefile.in is newer than Makefile.am (which should be the case if Makefile.am was not touched after the autogen.sh run). If Makefile.am has a younger modification date than Makefile.in, something was changed in this file after the autogen.sh run and autogen.sh should be reexecuted. I think it should be possible to do this automatically in the configure script/makefile.

This makes it a bit more complicated, but in this way it will work correctly on every distribution.

Comment by Brian Murrell (Inactive) [ 10/Mar/11 ]

But this solution is generally not (yet?) applicable outside of a debian/rules file. That's because debian packaging is the only packaging currently that allows patches to be applied "aftermarket". RPM building for example puts the entire source and patches into the tarball that is to be built. It could be done similarly to debian, by using a tarball created from a tag and apply patches in the spec file, but at this time it's not. At a time where it were done, a similar fix to this bug would be needed.

Outside of debian and rpm packaging, builds are typically done is an already fully patched (or checked out from git) tree so there is nothing to analyse to try to determine if autogen.sh is needed.

Your idea about creating dependency rules between the various .am and .in files is likely possible (although I'm not convinced it's not a chicken-and-egg problem since you need Makefiles in order to process make dependencies) but outside of the scope of this ticket I think.