[#LU-530] group qoutas not enforced

[LU-530] group qoutas not enforced Created: 22/Jul/11 Updated: 08/Aug/11 Resolved: 08/Aug/11
Status:	Resolved
Project:	Lustre
Component/s:	None
Affects Version/s:	Lustre 1.8.6
Fix Version/s:	Lustre 2.1.0, Lustre 1.8.7

Type:

Bug

Priority:

Major

Reporter:

Sven Trautmann (Inactive)

Assignee:

Niu Yawei (Inactive)

Resolution:

Fixed

Votes:

Labels:

None

Environment:

CentOS

Attachments:

0001-LU-530-group-quotas-not-enforced.patch

create_test_lustre.sh

create_test_lustre.txt

create_test_lustre_with_fix.txt

create_test_lustre_with_sync.txt

create_test_lustre_with_sync_and_second_dd.txt

lquota.tar.gz

Severity:

Bugzilla ID:

24,154

Rank (Obsolete):

4930

Description

Group quotas on Lustre 1.8.4 and 1.8.6 (issue has only been tested with these two versions) are not enforced.
A customer noticed, that user quotas are enforced, but group quotas are not (see BZ 24154).
I tried to reproduce this issue with Lustre 1.8.6 and found the same problem.
I've attached the script (create_test_lustre.sh) I used to verify the problem on a virtual machine.
The output of the script (create_test_lustre.txt) and the quota stats (lquota.tar.gz) is attached as well.
Is there something wrong with the way quotas are set up in this script or is this a real bug?

Comments

Comment by Sven Trautmann (Inactive) [ 22/Jul/11 ]

add lquota.tar.gz, with real data in it

Comment by Peter Jones [ 22/Jul/11 ]

Niu

Could you look at this one please?

Thanks

Peter

Comment by Niu Yawei (Inactive) [ 22/Jul/11 ]

Hi, Sven

I want to make sure it's not a cache write problem first, could you try do a sync after the first "sudo -u sven dd if=/dev/zero of=/scratch/lustre/client/zeros-sven bs=1M count=10" (for group quota test), then repeat the dd again to see if it fails for EDQUOT? Thanks.

Comment by Nathan Dauchy (Inactive) [ 22/Jul/11 ]

Sven can hopefully confirm with a quick test, but I don't think this is a cache issue. The OSTs may not be getting the quota information. Note the output of "lfs quota -v", where the OSTs are correctly tracking usage, but show "-" for the quota and "1" for the limit columns. This is consistent with what we saw on the production systems.
Thanks,
Nathan

Comment by Sven Trautmann (Inactive) [ 22/Jul/11 ]

output of test script with extra sync

Comment by Sven Trautmann (Inactive) [ 22/Jul/11 ]

Niu,
thanks for looking at this.
The script with an extra sync shows the same behaviour.

Comment by Sven Trautmann (Inactive) [ 22/Jul/11 ]

another output with a second dd

Comment by Niu Yawei (Inactive) [ 25/Jul/11 ]

There is a bug in which prevent OSS from sending back out of quota flag for group when the user quota of the file isn't enabled, I've made the patch to fix it, however, I got some trouble with my gerrit account recently, whenever it's fixed, I'll push the patch for review.

Just attach the patch here FYI.

Comment by Sven Trautmann (Inactive) [ 25/Jul/11 ]

Niu,
thanks, i tested your patch on my virtual machine. Works for me, however the quota for each OST is still reported as 1, see attachment.

Sven

Comment by Sven Trautmann (Inactive) [ 25/Jul/11 ]

output of create_test_lustre.sh with patch applied

Comment by Niu Yawei (Inactive) [ 25/Jul/11 ]

Hi, Sven

The output of "lfs quota ~~v" is correct, since lustre dosen't enable soft limit for quota slaves (OST), so the soft limit column for OST is "~~", and because the hard limit (100K) is too small for each slave having one qunit (128M) assigned, so the OST hard limit is set to the minimal limit: 1 quota block (1K).

Thanks
Niu

Comment by Sven Trautmann (Inactive) [ 25/Jul/11 ]

Hi Niu,

thanks for the clarification (and the fix),

Sven

Comment by Niu Yawei (Inactive) [ 29/Jul/11 ]

b1_8: http://review.whamcloud.com/1153
master: http://review.whamcloud.com/1156

Comment by Build Master (Inactive) [ 29/Jul/11 ]

Integrated in lustre-b1_8 » x86_64,client,el5,inkernel #118
~~LU-530~~ group quotas not enforced

Johann Lombardi : c55bdd6eea17ea470908a3ae8981a42e7231de05
Files :

lustre/quota/quota_interface.c

Comment by Build Master (Inactive) [ 29/Jul/11 ]

Integrated in lustre-b1_8 » x86_64,client,el5,ofa #118
~~LU-530~~ group quotas not enforced

Johann Lombardi : c55bdd6eea17ea470908a3ae8981a42e7231de05
Files :

lustre/quota/quota_interface.c

Comment by Build Master (Inactive) [ 29/Jul/11 ]

Integrated in lustre-b1_8 » x86_64,client,el6,inkernel #118
~~LU-530~~ group quotas not enforced

Johann Lombardi : c55bdd6eea17ea470908a3ae8981a42e7231de05
Files :

lustre/quota/quota_interface.c

Comment by Build Master (Inactive) [ 29/Jul/11 ]

Integrated in lustre-b1_8 » x86_64,server,el5,inkernel #118
~~LU-530~~ group quotas not enforced

Johann Lombardi : c55bdd6eea17ea470908a3ae8981a42e7231de05
Files :

lustre/quota/quota_interface.c

Comment by Build Master (Inactive) [ 29/Jul/11 ]

Integrated in lustre-b1_8 » x86_64,server,el5,ofa #118
~~LU-530~~ group quotas not enforced

Johann Lombardi : c55bdd6eea17ea470908a3ae8981a42e7231de05
Files :

lustre/quota/quota_interface.c

Comment by Build Master (Inactive) [ 29/Jul/11 ]

Integrated in lustre-b1_8 » x86_64,client,ubuntu1004,inkernel #118
~~LU-530~~ group quotas not enforced

Johann Lombardi : c55bdd6eea17ea470908a3ae8981a42e7231de05
Files :

lustre/quota/quota_interface.c

Comment by Build Master (Inactive) [ 29/Jul/11 ]

Integrated in lustre-b1_8 » i686,server,el5,inkernel #118
~~LU-530~~ group quotas not enforced

Johann Lombardi : c55bdd6eea17ea470908a3ae8981a42e7231de05
Files :

lustre/quota/quota_interface.c

Comment by Build Master (Inactive) [ 29/Jul/11 ]

Integrated in lustre-b1_8 » i686,client,el6,inkernel #118
~~LU-530~~ group quotas not enforced

Johann Lombardi : c55bdd6eea17ea470908a3ae8981a42e7231de05
Files :

lustre/quota/quota_interface.c

Comment by Build Master (Inactive) [ 29/Jul/11 ]

Integrated in lustre-b1_8 » i686,server,el5,ofa #118
~~LU-530~~ group quotas not enforced

Johann Lombardi : c55bdd6eea17ea470908a3ae8981a42e7231de05
Files :

lustre/quota/quota_interface.c

Comment by Build Master (Inactive) [ 29/Jul/11 ]

Integrated in lustre-b1_8 » i686,client,el5,inkernel #118
~~LU-530~~ group quotas not enforced

Johann Lombardi : c55bdd6eea17ea470908a3ae8981a42e7231de05
Files :

lustre/quota/quota_interface.c

Comment by Build Master (Inactive) [ 29/Jul/11 ]

Integrated in lustre-b1_8 » i686,client,el5,ofa #118
~~LU-530~~ group quotas not enforced

Johann Lombardi : c55bdd6eea17ea470908a3ae8981a42e7231de05
Files :

lustre/quota/quota_interface.c