[LU-533] lustre_types.h is missing, and replacement posix-types.h not included in user-space

• Status: Resolved
• Project: Lustre
• Affects Version/s: Lustre 2.1.0
• Fix Version/s: Lustre 2.1.0
• Type: Bug
• Priority: Minor
• Reporter: Christopher Morrone
• Assignee: Zhenyu Xu
• Resolution: Fixed
• Severity: 3

Description

The lustre_types.h header that was in 1.8 is not present on master. This means that any one including lustre/lustre_user.h in their user-space code is going to hit a compiler error.

Mining the git logs, it looks like

lustre/include/linux/lustre_types.h

from 1.8 was replaced in 2.0 by

libcfs/include/libcfs/posix/posix-types.h

as part of libcfs cleanup patches. However, posix-types.h is neither installed as part of lustre, nor included in the user-space header files.

I would think that posix-types.h needs to be installed under /usr/include/lustre and then conditionally included (!KERNEL) by lustre_user.h and any other headers that need it.

Issue Links

• is duplicated by: LU-4986 lustre_types.h gone

Comments

[Peter Jones]

Bobi

Could you please look into this one?

Thanks

Peter

[Christopher Morrone]

Potential fix is here:

http://review.whamcloud.com/1138

Needs testing though.

[Christopher Morrone]

Updated patch at http://review.whamcloud.com/1138.

[Zhenyu Xu]

Hi Andreas,

Should we put libcfs/include/* in the lustre rpm package and use "#include <libcfs/libcfs.h" in this case?

[Andreas Dilger]

No, there is too much internal stuff in libcfs/include/* to put all of it into the installed RPM package. Since programs including lustre_user.h from userspace will only ever want the posix/posix_types.h header, I think it is safe to only include that one header. We can re-examine using a generic libcfs/libcfs_types.h header if there are ever userspace arch issues that cause problems with using just posix_types.h.

[Christopher Morrone]

Fixed incorrect LU number in patch set three. No code change.

http://review.whamcloud.com/1138

[Build Master (Inactive)]

Integrated in lustre-master » x86_64,client,el5,ofa #247
LU-533 Include posix-types.h in headers and distribution

Oleg Drokin : f8e7a89c87b9d668d29f9ec31246e369205cc196
Files :

• lustre.spec.in
• lustre/include/lustre/lustre_user.h
• lustre/include/lustre/ll_fiemap.h
• libcfs/include/libcfs/posix/Makefile.am

[Build Master (Inactive)]

Integrated in lustre-master » x86_64,client,el5,inkernel #247
LU-533 Include posix-types.h in headers and distribution

Oleg Drokin : f8e7a89c87b9d668d29f9ec31246e369205cc196
Files :

• lustre/include/lustre/lustre_user.h
• lustre.spec.in
• libcfs/include/libcfs/posix/Makefile.am
• lustre/include/lustre/ll_fiemap.h

[Build Master (Inactive)]

Integrated in lustre-master » i686,client,el6,inkernel #247
LU-533 Include posix-types.h in headers and distribution

Oleg Drokin : f8e7a89c87b9d668d29f9ec31246e369205cc196
Files :

• lustre/include/lustre/lustre_user.h
• lustre.spec.in
• lustre/include/lustre/ll_fiemap.h
• libcfs/include/libcfs/posix/Makefile.am

[Build Master (Inactive)]

Integrated in lustre-master » x86_64,server,el6,inkernel #247
LU-533 Include posix-types.h in headers and distribution

Oleg Drokin : f8e7a89c87b9d668d29f9ec31246e369205cc196
Files :

• lustre/include/lustre/lustre_user.h
• lustre/include/lustre/ll_fiemap.h
• lustre.spec.in
• libcfs/include/libcfs/posix/Makefile.am

[Build Master (Inactive)]

Integrated in lustre-master » x86_64,client,sles11,inkernel #247
LU-533 Include posix-types.h in headers and distribution

Oleg Drokin : f8e7a89c87b9d668d29f9ec31246e369205cc196
Files :

• lustre.spec.in
• libcfs/include/libcfs/posix/Makefile.am
• lustre/include/lustre/ll_fiemap.h
• lustre/include/lustre/lustre_user.h

[Build Master (Inactive)]

Integrated in lustre-master » x86_64,server,el5,ofa #247
LU-533 Include posix-types.h in headers and distribution

Oleg Drokin : f8e7a89c87b9d668d29f9ec31246e369205cc196
Files :

• lustre/include/lustre/lustre_user.h
• libcfs/include/libcfs/posix/Makefile.am
• lustre/include/lustre/ll_fiemap.h
• lustre.spec.in

[Build Master (Inactive)]

Integrated in lustre-master » x86_64,client,el6,inkernel #247
LU-533 Include posix-types.h in headers and distribution

Oleg Drokin : f8e7a89c87b9d668d29f9ec31246e369205cc196
Files :

• libcfs/include/libcfs/posix/Makefile.am
• lustre.spec.in
• lustre/include/lustre/lustre_user.h
• lustre/include/lustre/ll_fiemap.h

[Build Master (Inactive)]

Integrated in lustre-master » x86_64,client,ubuntu1004,inkernel #247
LU-533 Include posix-types.h in headers and distribution

Oleg Drokin : f8e7a89c87b9d668d29f9ec31246e369205cc196
Files :

• lustre.spec.in
• lustre/include/lustre/lustre_user.h
• lustre/include/lustre/ll_fiemap.h
• libcfs/include/libcfs/posix/Makefile.am

[Build Master (Inactive)]

Integrated in lustre-master » i686,client,el5,inkernel #247
LU-533 Include posix-types.h in headers and distribution

Oleg Drokin : f8e7a89c87b9d668d29f9ec31246e369205cc196
Files :

• libcfs/include/libcfs/posix/Makefile.am
• lustre/include/lustre/ll_fiemap.h
• lustre.spec.in
• lustre/include/lustre/lustre_user.h

[Build Master (Inactive)]

Integrated in lustre-master » x86_64,server,el5,inkernel #247
LU-533 Include posix-types.h in headers and distribution

Oleg Drokin : f8e7a89c87b9d668d29f9ec31246e369205cc196
Files :

• libcfs/include/libcfs/posix/Makefile.am
• lustre/include/lustre/lustre_user.h
• lustre.spec.in
• lustre/include/lustre/ll_fiemap.h

[Build Master (Inactive)]

Integrated in lustre-master » i686,server,el5,ofa #247
LU-533 Include posix-types.h in headers and distribution

Oleg Drokin : f8e7a89c87b9d668d29f9ec31246e369205cc196
Files :

• libcfs/include/libcfs/posix/Makefile.am
• lustre/include/lustre/lustre_user.h
• lustre/include/lustre/ll_fiemap.h
• lustre.spec.in

[Build Master (Inactive)]

Integrated in lustre-master » i686,server,el6,inkernel #247
LU-533 Include posix-types.h in headers and distribution

Oleg Drokin : f8e7a89c87b9d668d29f9ec31246e369205cc196
Files :

• lustre/include/lustre/lustre_user.h
• libcfs/include/libcfs/posix/Makefile.am
• lustre.spec.in
• lustre/include/lustre/ll_fiemap.h

[Build Master (Inactive)]

Integrated in lustre-master » i686,client,el5,ofa #247
LU-533 Include posix-types.h in headers and distribution

Oleg Drokin : f8e7a89c87b9d668d29f9ec31246e369205cc196
Files :

• libcfs/include/libcfs/posix/Makefile.am
• lustre.spec.in
• lustre/include/lustre/lustre_user.h
• lustre/include/lustre/ll_fiemap.h

[Build Master (Inactive)]

Integrated in lustre-master » i686,server,el5,inkernel #247
LU-533 Include posix-types.h in headers and distribution

Oleg Drokin : f8e7a89c87b9d668d29f9ec31246e369205cc196
Files :

• lustre/include/lustre/ll_fiemap.h
• lustre/include/lustre/lustre_user.h
• lustre.spec.in
• libcfs/include/libcfs/posix/Makefile.am

[Peter Jones]

Is any more work required here or can this ticket be marked as resolved?

[Christopher Morrone]

It can be marked resolved.

[Andreas Dilger]

Patch landed for 2.1.0 release.