"lctl {get,set}_param" should also check in /sys/fs/{lnet,lustre} (LU-5030)

[LU-5330] remove deprecated full path tunable access in lustre config utils Created: 11/Jul/14  Updated: 14/Nov/14  Resolved: 14/Nov/14

Status: Resolved
Project: Lustre
Component/s: None
Affects Version/s: Lustre 2.7.0
Fix Version/s: Lustre 2.7.0

Type: Technical task Priority: Critical
Reporter: Oleg Drokin Assignee: Nathaniel Clark
Resolution: Fixed Votes: 0
Labels: bb

Issue Links:
Related
is related to LU-5030 "lctl {get,set}_param" should also ch... Resolved
Rank (Obsolete): 14872

 Description   

lustre/utils/lustre_cfg.c::lprocfs_param_pattern has this warning that needs to be taken care of now:

                if (!warned) {
                        fprintf(stderr, "%s: specifying parameters via "
                                "full paths is deprecated.\n", cmd);
#if LUSTRE_VERSION_CODE >= OBD_OCD_VERSION(2, 6, 51, 0)
#warning "remove deprecated full path tunable access"
#endif
                        warned = 1;
                }
                snprintf(buf, buf_size, "%s", path);


 Comments   
Comment by Bruno Faccini (Inactive) [ 16/Aug/14 ]

I just rebased a patch on top of latest master and triggered this warning/failure during the build :
https://build.hpdd.intel.com/job/lustre-reviews/25915/

Seems that we just reached the 2.6.51 version, as indicated by :

commit 26bc216c8a25db00c4cf3e23bd6cf175610963ea
Author: Oleg Drokin <oleg.drokin@intel.com>
Date:   Fri Aug 15 18:17:13 2014 -0400

    New tag 2.6.51
    
    Change-Id: I45f7812fd7e4d061f2605579c8bac4671a24e202
Comment by Peter Jones [ 18/Aug/14 ]

Nathaniel

Could you please look into this one?

Thanks

Peter

Comment by James A Simmons [ 26/Aug/14 ]

Actually I will be addressing this with the LU-5030 work. This can be linked to the LU-5030 since this is the case.

Comment by Andreas Dilger [ 14/Nov/14 ]

This was fixed for 2.7 as part of http://review.whamcloud.com/9545 LU-4730 utils: lctl get_param, set_param cleanup

Generated at Sat Feb 10 01:50:33 UTC 2024 using Jira 9.4.14#940014-sha1:734e6822bbf0d45eff9af51f82432957f73aa32c.