[LU-5370] mdt_open_by_fid_lock() may return -EREMOTE without setting lock handle

• Status: Resolved
• Project: Lustre
• Affects Version/s: Lustre 2.7.0
• Fix Version/s: Lustre 2.7.0
• Type: Bug
• Priority: Critical
• Reporter: John Hammond
• Assignee: John Hammond
• Resolution: Fixed
• Labels: fault, mdt
• Severity: 3

Description

In mdt_open_by_fid_lock() if rr_fid2 designates a remote object then we return -EREMOTE without taking a lock. Later in mdt_intent_reint() this will crash:

       /* the open lock or the lock for cross-ref object should be                       
         * returned to the client */
        if (rc == -EREMOTE || mdt_get_disposition(rep, DISP_OPEN_LOCK)) {
                LASSERT(lustre_handle_is_used(&lhc->mlh_reg_lh));
                rep->lock_policy_res2 = 0;
                rc = mdt_intent_lock_replace(info, lockp, lhc, flags);
                RETURN(rc);
        }

Issue Links

• is related to: LU-5369 servers should reject invalid FIDs, r...

Comments

[John Hammond]

Please see http://review.whamcloud.com/11218.

[Jodi Levi (Inactive)]

Patch landed to Master.