[LU-54] LPSZ should be removed from 1.8 to match master

• Status: Resolved
• Project: Lustre
• Affects Version/s: Lustre 1.8.6
• Fix Version/s: Lustre 1.8.6
• Type: Bug
• Priority: Minor
• Reporter: Kit Westneat (Inactive)
• Assignee: Niu Yawei (Inactive)
• Resolution: Fixed
• Severity: 3
• Bugzilla ID: 22,729

Description

As described in bug 22729, the use of LPSZ should be removed for portability purposes, as well as to match the master branch.

As Andreas says:
"""
To be honest, I'd rather just get rid of LPSZ and cast the values
to (int) or (long) and use %u or %lu as needed. For the 10 or 15
places that we use LPSZ in b1_8 I think we should just get rid of it.

See my earlier comment that LPSZ has been removed entirely from
master, so I'd rather modify the b1_8 code to be more like master
instead of moving away from it.
"""

Comments

[Peter Jones]

Niu will be looking into this one

[Niu Yawei (Inactive)]

patch is ready for review.http://review.whamcloud.com/219

[Peter Jones]

Niu

I suggest that you get Johann's approval for this change. He starts with us next week.

Regards

Peter

[Niu Yawei (Inactive)]

Yes, I've posted the patch in b22729 and added Johann for review. Whenever he joined us, I'll add him in Jira to review this patch.

[Build Master (Inactive)]

Integrated in reviews-centos5 #565
LU-54 Remove LPSZ & LPSSZ

Niu Yawei : a95f4e3938e9db452afeb97b104c6139a9c9da28
Files :

• lustre/llite/lproc_llite.c
• lnet/include/libcfs/linux/kp30.h
• lnet/include/libcfs/darwin/kp30.h
• lustre/obdclass/obd_mount.c
• lnet/klnds/gmlnd/gmlnd_comm.c
• lnet/include/libcfs/winnt/kp30.h
• lustre/obdclass/class_obd.c
• lustre/include/darwin/lustre_user.h
• lnet/autoconf/lustre-lnet.m4
• lustre/llite/rw26.c
• lustre/lvfs/fsfilt_ext3.c
• lustre/llite/file.c
• lustre/mds/mds_join.c

[Peter Jones]

Niu

Does the version of the patch passed upstream to Oracle for landing need updating? I expect to see it landed soon...

Peter

[Niu Yawei (Inactive)]

No, there isn't change, I just re-push it for passing the build. (originally, the build will fail on ubuntu for some other bug which Brian was working on)

[Peter Jones]

Good - thanks for confirming!

[Peter Jones]

Niu,

Landing permission has been granted by Oracle for this change. Can you please send the patch to [e-mail]

Thanks

Peter

[Peter Jones]

Oracle have landed this change upstream for 1.8.6 and it is already landed for master so mark as resolve