[#LU-542] Missing XATTR changelog record

[LU-542] Missing XATTR changelog record Created: 27/Jul/11 Updated: 08/Apr/12 Resolved: 06/Dec/11
Status:	Resolved
Project:	Lustre
Component/s:	None
Affects Version/s:	Lustre 2.0.0, Lustre 2.1.0
Fix Version/s:	Lustre 2.2.0, Lustre 2.1.2

Type:

Bug

Priority:

Minor

Reporter:

Thomas LEIBOVICI - CEA (Inactive)

Assignee:

Zhenyu Xu

Resolution:

Fixed

Votes:

Labels:

None

Severity:

Rank (Obsolete):

4839

Description

Creating or modifying an xattr generate a XATTR record in MDT changelog,
but removing an xattr doesn't. I think it's a lack, since removing an xattr is an xattr change too.

Comments

Comment by Zhenyu Xu [ 28/Jul/11 ]

There is a logic typo in mdd_xattr_del()

File:lustre\mdd\mdd_object.c Func:mdd_xattr_del()

        /* Only record user xattr changes */
        if ((rc == 0) && (strncmp("user.", name, 5) != 0))
                rc = mdd_changelog_data_store(env, mdd, CL_XATTR, 0, mdd_obj,
                                              handle);

Comment by Zhenyu Xu [ 28/Jul/11 ]

patch tracking at http://review.whamcloud.com/1158

Comment by Build Master (Inactive) [ 06/Dec/11 ]

Integrated in lustre-master » i686,client,el6,inkernel #368
~~LU-542~~ Fix mdt xattr handler logic error (Revision 383f5453a8c3a903b0fd2239dd3922c75d9a76b2)

Result = SUCCESS
Oleg Drokin : 383f5453a8c3a903b0fd2239dd3922c75d9a76b2
Files :

lustre/mdd/mdd_object.c

Comment by Build Master (Inactive) [ 06/Dec/11 ]

Integrated in lustre-master » x86_64,server,el6,inkernel #368
~~LU-542~~ Fix mdt xattr handler logic error (Revision 383f5453a8c3a903b0fd2239dd3922c75d9a76b2)

Result = SUCCESS
Oleg Drokin : 383f5453a8c3a903b0fd2239dd3922c75d9a76b2
Files :

lustre/mdd/mdd_object.c

Comment by Build Master (Inactive) [ 06/Dec/11 ]

Integrated in lustre-master » x86_64,server,el5,ofa #368
~~LU-542~~ Fix mdt xattr handler logic error (Revision 383f5453a8c3a903b0fd2239dd3922c75d9a76b2)

Result = SUCCESS
Oleg Drokin : 383f5453a8c3a903b0fd2239dd3922c75d9a76b2
Files :

lustre/mdd/mdd_object.c

Comment by Build Master (Inactive) [ 06/Dec/11 ]

Integrated in lustre-master » x86_64,client,sles11,inkernel #368
~~LU-542~~ Fix mdt xattr handler logic error (Revision 383f5453a8c3a903b0fd2239dd3922c75d9a76b2)

Result = SUCCESS
Oleg Drokin : 383f5453a8c3a903b0fd2239dd3922c75d9a76b2
Files :

lustre/mdd/mdd_object.c

Comment by Build Master (Inactive) [ 06/Dec/11 ]

Integrated in lustre-master » x86_64,client,el6,inkernel #368
~~LU-542~~ Fix mdt xattr handler logic error (Revision 383f5453a8c3a903b0fd2239dd3922c75d9a76b2)

Result = SUCCESS
Oleg Drokin : 383f5453a8c3a903b0fd2239dd3922c75d9a76b2
Files :

lustre/mdd/mdd_object.c

Comment by Build Master (Inactive) [ 06/Dec/11 ]

Integrated in lustre-master » x86_64,client,ubuntu1004,inkernel #368
~~LU-542~~ Fix mdt xattr handler logic error (Revision 383f5453a8c3a903b0fd2239dd3922c75d9a76b2)

Result = SUCCESS
Oleg Drokin : 383f5453a8c3a903b0fd2239dd3922c75d9a76b2
Files :

lustre/mdd/mdd_object.c

Comment by Build Master (Inactive) [ 06/Dec/11 ]

Integrated in lustre-master » i686,client,el5,ofa #368
~~LU-542~~ Fix mdt xattr handler logic error (Revision 383f5453a8c3a903b0fd2239dd3922c75d9a76b2)

Result = SUCCESS
Oleg Drokin : 383f5453a8c3a903b0fd2239dd3922c75d9a76b2
Files :

lustre/mdd/mdd_object.c

Comment by Build Master (Inactive) [ 06/Dec/11 ]

Integrated in lustre-master » i686,client,el5,inkernel #368
~~LU-542~~ Fix mdt xattr handler logic error (Revision 383f5453a8c3a903b0fd2239dd3922c75d9a76b2)

Result = SUCCESS
Oleg Drokin : 383f5453a8c3a903b0fd2239dd3922c75d9a76b2
Files :

lustre/mdd/mdd_object.c

Comment by Build Master (Inactive) [ 06/Dec/11 ]

Integrated in lustre-master » x86_64,client,el5,inkernel #368
~~LU-542~~ Fix mdt xattr handler logic error (Revision 383f5453a8c3a903b0fd2239dd3922c75d9a76b2)

Result = SUCCESS
Oleg Drokin : 383f5453a8c3a903b0fd2239dd3922c75d9a76b2
Files :

lustre/mdd/mdd_object.c

Comment by Build Master (Inactive) [ 06/Dec/11 ]

Integrated in lustre-master » x86_64,client,el5,ofa #368
~~LU-542~~ Fix mdt xattr handler logic error (Revision 383f5453a8c3a903b0fd2239dd3922c75d9a76b2)

Result = SUCCESS
Oleg Drokin : 383f5453a8c3a903b0fd2239dd3922c75d9a76b2
Files :

lustre/mdd/mdd_object.c

Comment by Build Master (Inactive) [ 06/Dec/11 ]

Integrated in lustre-master » i686,server,el6,inkernel #368
~~LU-542~~ Fix mdt xattr handler logic error (Revision 383f5453a8c3a903b0fd2239dd3922c75d9a76b2)

Result = SUCCESS
Oleg Drokin : 383f5453a8c3a903b0fd2239dd3922c75d9a76b2
Files :

lustre/mdd/mdd_object.c

Comment by Build Master (Inactive) [ 06/Dec/11 ]

Integrated in lustre-master » x86_64,server,el5,inkernel #368
~~LU-542~~ Fix mdt xattr handler logic error (Revision 383f5453a8c3a903b0fd2239dd3922c75d9a76b2)

Result = SUCCESS
Oleg Drokin : 383f5453a8c3a903b0fd2239dd3922c75d9a76b2
Files :

lustre/mdd/mdd_object.c

Comment by Peter Jones [ 06/Dec/11 ]

Landed for 2.2

Comment by Build Master (Inactive) [ 06/Dec/11 ]

Integrated in lustre-master » i686,server,el5,inkernel #368
~~LU-542~~ Fix mdt xattr handler logic error (Revision 383f5453a8c3a903b0fd2239dd3922c75d9a76b2)

Result = SUCCESS
Oleg Drokin : 383f5453a8c3a903b0fd2239dd3922c75d9a76b2
Files :

lustre/mdd/mdd_object.c