[LU-5442] unconditionally include libcfs.h in lustre_idl.h Created: 01/Aug/14  Updated: 11/Aug/14  Resolved: 11/Aug/14

Status: Closed
Project: Lustre
Component/s: None
Affects Version/s: Lustre 2.7.0
Fix Version/s: Lustre 2.7.0

Type: Bug Priority: Minor
Reporter: John Hammond Assignee: John Hammond
Resolution: Fixed Votes: 0
Labels: None

Severity: 3
Rank (Obsolete): 15156

 Description   

lustre_idl.h only includes libcfs.h if LPU64 is not defined:

#if !defined(LPU64)
#include <libcfs/libcfs.h> /* for LPUX64, etc */
#endif

Since the landing of LU-5327 libcfs: add libcfs/types.h it is possible to get definitions for LPU64 without including libcfs.h. (Technically it was always possible, but now it's much easier.)

The outer include guard was added in LU-113: make lustre_

{idl,user}

.h nice to userspace. Since we no longer package lustre_idl.h we should remove this guard.



 Comments   
Comment by John Hammond [ 01/Aug/14 ]

Please see http://review.whamcloud.com/11308.

Comment by John Hammond [ 11/Aug/14 ]

Patch landed to master.

Generated at Sat Feb 10 01:51:31 UTC 2024 using Jira 9.4.14#940014-sha1:734e6822bbf0d45eff9af51f82432957f73aa32c.