[LU-5448] Compilation without libreadline broken by LU-5418

• Status: Closed
• Project: Lustre
• Type: Bug
• Priority: Minor
• Reporter: Patrick Farrell (Inactive)
• Assignee: WC Triage
• Resolution: Duplicate

Environment

CentOS 6.5, latest master.

• Severity: 3

Description

The two void declarations added by LU-5418 (http://review.whamcloud.com/11231):
static void noop_int_fn(int unused) { }
static void noop_void_fn(void) { }

Are not used if HAVE_LIBREADLINE is not defined, which results in a compilation error:

cc1: warnings being treated as errors
util/parser.c:286: error: 'noop_int_fn' defined but not used
util/parser.c:287: error: 'noop_void_fn' defined but not used
make[5]: *** [libcfsutil_a-parser.o] Error 1
make[5]: *** Waiting for unfinished jobs....
make[4]: *** [all-recursive] Error 1
make[3]: *** [all-recursive] Error 1
make[2]: *** [all-recursive] Error 1
make[1]: *** [all] Error 2
error: Bad exit status from /var/tmp/rpm-tmp.nePJql (%build)

Fix is easy, just wrap those declarations in #ifdef HAVE_LIBREADLINE.

Patch coming momentarily.

Issue Links

• is duplicated by: LU-5418 compile fix for code using readline
• is duplicated by: LU-5445 fail to build util/parser.c

Comments

[Bob Glossman (Inactive)]

patch is already in flight: http://review.whamcloud.com/#/c/11252

[Bob Glossman (Inactive)]

as a workaround, just install the readline-devel rpm. with that installed HAVE_LIBREADLINE gets #define'd and the noop routines get used.

[Patrick Farrell (Inactive)]

http://review.whamcloud.com/11318

[Patrick Farrell (Inactive)]

Whoops - Thanks, Bob. I searched but didn't find your ticket, obviously. Nevermind, then. I'll abandon the patch.