[LU-5504] Missing "const" qualifier in changelog record accessors

• Status: Resolved
• Project: Lustre
• Affects Version/s: Lustre 2.6.0, Lustre 2.5.2, Lustre 2.4.3
• Fix Version/s: Lustre 2.8.0
• Type: Improvement
• Priority: Minor
• Reporter: Thomas LEIBOVICI - CEA (Inactive)
• Assignee: James Nunez (Inactive)
• Resolution: Fixed
• Labels: patch

Description

The following function prototypes in "lustre_user.h" require read/write access to their "rec" argument but they don't need to modify it:

static inline int changelog_rec_size(struct changelog_rec *rec);
static inline char *changelog_rec_name(struct changelog_rec *rec);
static inline int changelog_rec_snamelen(struct changelog_ext_rec *rec);
static inline char *changelog_rec_sname(struct changelog_ext_rec *rec);

Qualifying the "rec" argument as "const" would be more rigourous, and would avoid such messages when using them:
warning: passing argument 1 of 'changelog_rec_snamelen' discards qualifiers from pointer target type
/usr/include/lustre/lustre_user.h:844: note: expected 'struct changelog_ext_rec *' but argument is of type 'const struct changelog_ext_rec *'
warning: passing argument 1 of 'changelog_rec_sname' discards qualifiers from pointer target type
/usr/include/lustre/lustre_user.h:849: note: expected 'struct changelog_ext_rec *' but argument is of type 'const struct changelog_ext_rec *'

I will submit a patch to make these prototypes more strict.

Comments

[Thomas LEIBOVICI - CEA (Inactive)]

Change submitted as: http://review.whamcloud.com/#/c/11517/

[Peter Jones]

James

Can you please take care of this patch?

Thanks

Peter

[James Nunez (Inactive)]

Landed to master

[Frank Zago (Inactive)]

This was accidentally reverted in 0f22e4.

Can this bug be re-opened?

[Gerrit Updater]

frank zago ([e-mail]) uploaded a new patch: http://review.whamcloud.com/13787
Subject: LU-5504 utils: add const qualifier to changelog accessors.
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 4456a3e7815594337b4f6996bf1cfcc0e7f24572

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch http://review.whamcloud.com/13787/
Subject: LU-5504 utils: add const qualifier to changelog accessors.
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 7505b4e4f99af589ce09ef97d21f0abc00ae79a8

[Peter Jones]

Landed for 2.8