[LU-555] ll_have_md_lock() code optimization

• Status: Resolved
• Project: Lustre
• Affects Version/s: Lustre 2.1.0
• Fix Version/s: Lustre 2.2.0
• Type: Improvement
• Priority: Minor
• Reporter: CEA
• Assignee: Peter Jones
• Resolution: Fixed

Description

Suggested by Andreas:
in ll_md_blocking_ast(), Instead of doing multiple searches for these lock bits, it makes more sense to change ll_have_md_lock() to take "&bits" as the parameter (instead of a specific single bit), and then it can do a search on the first bit in the mask. If any lock is found, it can zero out all of the set lock bits in the lock from "&bits".

In the common case where there are multiple bits set in the lock this will avoid calling ll_have_md_lock->md_lock_match() multiple times for each file.

Comments

[jacques-charles lafoucriere]

Please assign me this bug (I did not find how to take it)

[Peter Jones]

JC

It seems that only Whamcloud engineers can be assigned tickets so I will assign it to myself even though you are really the owner.

Peter

[Build Master (Inactive)]

Integrated in lustre-master » x86_64,server,el5,ofa #311
LU-555 ll_have_md_lock() optimization to accelerate multiple bits locks

Oleg Drokin : cc2836737d5401ad48e2aaf64db035d11e795ae5
Files :

• lustre/llite/llite_capa.c
• lustre/llite/dcache.c
• lustre/llite/namei.c
• lustre/llite/llite_internal.h
• lustre/llite/file.c

[Build Master (Inactive)]

Integrated in lustre-master » x86_64,client,el5,inkernel #311
LU-555 ll_have_md_lock() optimization to accelerate multiple bits locks

Oleg Drokin : cc2836737d5401ad48e2aaf64db035d11e795ae5
Files :

• lustre/llite/namei.c
• lustre/llite/dcache.c
• lustre/llite/llite_capa.c
• lustre/llite/llite_internal.h
• lustre/llite/file.c

[Build Master (Inactive)]

Integrated in lustre-master » i686,client,el6,inkernel #311
LU-555 ll_have_md_lock() optimization to accelerate multiple bits locks

Oleg Drokin : cc2836737d5401ad48e2aaf64db035d11e795ae5
Files :

• lustre/llite/file.c
• lustre/llite/llite_internal.h
• lustre/llite/namei.c
• lustre/llite/llite_capa.c
• lustre/llite/dcache.c

[Build Master (Inactive)]

Integrated in lustre-master » x86_64,server,el6,inkernel #311
LU-555 ll_have_md_lock() optimization to accelerate multiple bits locks

Oleg Drokin : cc2836737d5401ad48e2aaf64db035d11e795ae5
Files :

• lustre/llite/llite_internal.h
• lustre/llite/llite_capa.c
• lustre/llite/dcache.c
• lustre/llite/namei.c
• lustre/llite/file.c

[Build Master (Inactive)]

Integrated in lustre-master » x86_64,server,el5,inkernel #311
LU-555 ll_have_md_lock() optimization to accelerate multiple bits locks

Oleg Drokin : cc2836737d5401ad48e2aaf64db035d11e795ae5
Files :

• lustre/llite/file.c
• lustre/llite/llite_capa.c
• lustre/llite/llite_internal.h
• lustre/llite/namei.c
• lustre/llite/dcache.c

[Build Master (Inactive)]

Integrated in lustre-master » x86_64,client,sles11,inkernel #311
LU-555 ll_have_md_lock() optimization to accelerate multiple bits locks

Oleg Drokin : cc2836737d5401ad48e2aaf64db035d11e795ae5
Files :

• lustre/llite/llite_capa.c
• lustre/llite/file.c
• lustre/llite/dcache.c
• lustre/llite/namei.c
• lustre/llite/llite_internal.h

[Build Master (Inactive)]

Integrated in lustre-master » x86_64,client,ubuntu1004,inkernel #311
LU-555 ll_have_md_lock() optimization to accelerate multiple bits locks

Oleg Drokin : cc2836737d5401ad48e2aaf64db035d11e795ae5
Files :

• lustre/llite/llite_internal.h
• lustre/llite/llite_capa.c
• lustre/llite/namei.c
• lustre/llite/dcache.c
• lustre/llite/file.c

[Build Master (Inactive)]

Integrated in lustre-master » x86_64,client,el5,ofa #311
LU-555 ll_have_md_lock() optimization to accelerate multiple bits locks

Oleg Drokin : cc2836737d5401ad48e2aaf64db035d11e795ae5
Files :

• lustre/llite/llite_internal.h
• lustre/llite/namei.c
• lustre/llite/llite_capa.c
• lustre/llite/file.c
• lustre/llite/dcache.c

[Build Master (Inactive)]

Integrated in lustre-master » x86_64,client,el6,inkernel #311
LU-555 ll_have_md_lock() optimization to accelerate multiple bits locks

Oleg Drokin : cc2836737d5401ad48e2aaf64db035d11e795ae5
Files :

• lustre/llite/namei.c
• lustre/llite/llite_capa.c
• lustre/llite/llite_internal.h
• lustre/llite/dcache.c
• lustre/llite/file.c

[Build Master (Inactive)]

Integrated in lustre-master » i686,client,el5,ofa #311
LU-555 ll_have_md_lock() optimization to accelerate multiple bits locks

Oleg Drokin : cc2836737d5401ad48e2aaf64db035d11e795ae5
Files :

• lustre/llite/llite_internal.h
• lustre/llite/file.c
• lustre/llite/namei.c
• lustre/llite/llite_capa.c
• lustre/llite/dcache.c

[Build Master (Inactive)]

Integrated in lustre-master » i686,client,el5,inkernel #311
LU-555 ll_have_md_lock() optimization to accelerate multiple bits locks

Oleg Drokin : cc2836737d5401ad48e2aaf64db035d11e795ae5
Files :

• lustre/llite/llite_capa.c
• lustre/llite/file.c
• lustre/llite/llite_internal.h
• lustre/llite/dcache.c
• lustre/llite/namei.c

[Build Master (Inactive)]

Integrated in lustre-master » i686,server,el5,ofa #311
LU-555 ll_have_md_lock() optimization to accelerate multiple bits locks

Oleg Drokin : cc2836737d5401ad48e2aaf64db035d11e795ae5
Files :

• lustre/llite/namei.c
• lustre/llite/file.c
• lustre/llite/dcache.c
• lustre/llite/llite_internal.h
• lustre/llite/llite_capa.c

[Build Master (Inactive)]

Integrated in lustre-master » i686,server,el5,inkernel #311
LU-555 ll_have_md_lock() optimization to accelerate multiple bits locks

Oleg Drokin : cc2836737d5401ad48e2aaf64db035d11e795ae5
Files :

• lustre/llite/llite_internal.h
• lustre/llite/dcache.c
• lustre/llite/namei.c
• lustre/llite/llite_capa.c
• lustre/llite/file.c

[Build Master (Inactive)]

Integrated in lustre-master » i686,server,el6,inkernel #311
LU-555 ll_have_md_lock() optimization to accelerate multiple bits locks

Oleg Drokin : cc2836737d5401ad48e2aaf64db035d11e795ae5
Files :

• lustre/llite/llite_internal.h
• lustre/llite/namei.c
• lustre/llite/llite_capa.c
• lustre/llite/dcache.c
• lustre/llite/file.c