[LU-5577] comparison between signed and unsigned integer expressions

• Status: Resolved
• Project: Lustre
• Affects Version/s: Lustre 2.7.0
• Fix Version/s: Lustre 2.7.0
• Type: Bug
• Priority: Minor
• Reporter: Dmitry Eremin (Inactive)
• Assignee: Dmitry Eremin (Inactive)
• Resolution: Fixed
• Severity: 3

Description

This ticket is for cleanup patches that should remove warnings about comparison between signed and unsigned integer expressions.

Some of them cause real issue in code.

Issue Links

• is related to: LU-6303 comparison between signed and unsigne...
• is related to: LU-2753 Tracking bug for static code analysis...
• is related to: LU-6215 Sync Lustre external tree with lustre...
• is related to: LU-5439 Function lustre_msg_buflen() can retu...

Comments

[Dmitry Eremin (Inactive)]

Patches are: http://review.whamcloud.com/#/q/message:LU-5577+is:open,n,z

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch http://review.whamcloud.com/12385/
Subject: LU-5577 obdclass: lu_htable_order() return type to long
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 8475dda6d6d96ff021f045e15c3a65fbd7736de8

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch http://review.whamcloud.com/12387/
Subject: LU-5577 obdclass: change loop indexes to unsigned
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: c1352f54dba21d36581001043f7182f561c87f95

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch http://review.whamcloud.com/12378/
Subject: LU-5577 obd: change brw_page->count to unsigned
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 34c03a21c044af07ea3dd9008c154b77107b55fb

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch http://review.whamcloud.com/12379/
Subject: LU-5577 libcfs: fix warnings in libcfs/curproc.h
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: d39408943a56f452d68b3c8b170ee4ce10e416fa

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch http://review.whamcloud.com/12380/
Subject: LU-5577 obdclass: change cl_fault_io->ft_nob to size_t
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: ca58021173bbfe465a13cd34cc42b12fe5af31e4

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch http://review.whamcloud.com/12382/
Subject: LU-5577 obdclass: (*dt_index_page_build_t) arg nob to size_t
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: a2245cbf99d15a24605e355f26b7612895ae2287

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch http://review.whamcloud.com/12388/
Subject: LU-5577 obdclass: do_body_ops->dbo_

{read,write}

return ssize_t
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 83efcf39e2f88ecd3cf5162c0f5cead2c39a5de3

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch http://review.whamcloud.com/12475/
Subject: LU-5577 ptlrpc: fix comparison between signed and unsigned
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 24c4f3a53b9ca5ec2c6f8c71e166f579d8838137

[Gerrit Updater]

Dmitry Eremin ([e-mail]) uploaded a new patch: http://review.whamcloud.com/13125
Subject: LU-5577 obd: change type of cl_conn_count to size_t
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 08889454c636be25f4151ae322af0c1312d6fb08

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch http://review.whamcloud.com/12386/
Subject: LU-5577 osc: change cl_extent_tax and *grants to unsigned
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: a2cbc7d543a54f33d4e84bcd0465b7029aa1c82d

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch http://review.whamcloud.com/13125/
Subject: LU-5577 obd: change type of cl_conn_count to size_t
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 5e17af16a920c56eba438faf7cb66f55c70e0b79

[James A Simmons]

All patches have been merged.

[Dmitry Eremin (Inactive)]

Unfortunately there are many warnings still exist. I'm going to continue this work. So, new patches will be coming...

[Andreas Dilger]

All patches under this bug have been landed for 2.7.0. Closing it and opened LU-6303 for future patches.