[LU-5592] incorrect check for NULL in ofd_version_get_check()

• Status: Resolved
• Project: Lustre
• Fix Version/s: Lustre 2.7.0
• Type: Bug
• Priority: Major
• Reporter: Dmitry Eremin (Inactive)
• Assignee: Dmitry Eremin (Inactive)
• Resolution: Fixed
• Labels: kw
• Severity: 3

Description

int ofd_version_get_check(struct ofd_thread_info *info,
			  struct ofd_object *fo)
{
	dt_obj_version_t curr_version;

	LASSERT(ofd_object_exists(fo));

	if (info->fti_exp)
		RETURN(0);
...
		spin_lock(&info->fti_exp->exp_lock);
		info->fti_exp->exp_vbr_failed = 1;
		spin_unlock(&info->fti_exp->exp_lock);
		RETURN (-EOVERFLOW);
	}
	info->fti_pre_version = curr_version;
	RETURN(0);
}

Comments

[Dmitry Eremin (Inactive)]

patch is http://review.whamcloud.com/11773/

[Andreas Dilger]

It looks like this change was introduced in http://review.whamcloud.com/7667 (commit 730a204e7366):

LU-3951 lfsck: OST-object inconsistency self detect/repair

@@ -53,7 +53,9 @@ int ofd_version_get_check(struct ofd_thread_info *info,
        dt_obj_version_t curr_version;
 
        LASSERT(ofd_object_exists(fo));
-       LASSERT(info->fti_exp);
+
+       if (info->fti_exp)
+               RETURN(0);

but it isn't clear whether the bug is in the "if" check added, or in the debug message.

[nasf (Inactive)]

The "if" check was wrong, It was added because the original "LASSERT(info->fti_exp);" failed during the test.

[Dmitry Eremin (Inactive)]

Landed to master.