[LU-5631] Incorrect swabbing of struct llog_rec_tail Created: 16/Sep/14 Updated: 01/Dec/14 Resolved: 18/Sep/14 |
|
| Status: | Resolved |
| Project: | Lustre |
| Component/s: | None |
| Affects Version/s: | Lustre 2.7.0 |
| Fix Version/s: | Lustre 2.7.0, Lustre 2.5.4 |
| Type: | Bug | Priority: | Major |
| Reporter: | Henri Doreau (Inactive) | Assignee: | James Nunez (Inactive) |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | patch | ||
| Issue Links: |
|
||||||||
| Severity: | 3 | ||||||||
| Rank (Obsolete): | 15747 | ||||||||
| Description |
|
llog_rec_tail is accessed directly (tail = &cr->cr_tail) in lustre_swab_llog_rec, though it comes after a variable length structure. This lead to the cr_name field of the changelog_record being shuffled and the actual tail being left untouched... |
| Comments |
| Comment by Henri Doreau (Inactive) [ 16/Sep/14 ] |
|
Patch at http://review.whamcloud.com/11937 |
| Comment by Peter Jones [ 16/Sep/14 ] |
|
James Could you please take care of this patch? Thanks Peter |
| Comment by Andreas Dilger [ 16/Sep/14 ] |
|
The patch in http://review.whamcloud.com/4060 would also fix this bug and would be better to land for master. |
| Comment by Henri Doreau (Inactive) [ 17/Sep/14 ] |
|
Patch applies as is on 2.4 and 2.5, here they are: b2_4: http://review.whamcloud.com/#/c/11954/ |
| Comment by Gerrit Updater [ 01/Dec/14 ] |
|
Oleg Drokin (oleg.drokin@intel.com) merged in patch http://review.whamcloud.com/11953/ |