[LU-5680] sanity-hsm uses /etc/motd (which is probably of size 0)

• Status: Closed
• Project: Lustre
• Affects Version/s: Lustre 2.11.0, Lustre 2.10.4
• Fix Version/s: Lustre 2.12.1
• Type: Bug
• Priority: Minor
• Reporter: John Hammond
• Assignee: James Nunez (Inactive)
• Resolution: Fixed
• Labels: hsm, ubuntu
• Severity: 3

Description

In various tests sanity-hsm copies /etc/hosts, /etc/passwd, or /etc/modt for use as the test file. /etc/motd is likely of size 0 and may defeat the use of bandwidth control for timing. Uses of /etc/* should be replaced with a generated files of known suitable size. We should also add explicit tests using files of size 0.

Issue Links

• is related to: LU-10469 sanity-hsm on ubuntu: cp: cannot stat...

Comments

[Jodi Levi (Inactive)]

Hi James,
Could you have a look at this one?
Thank you!

[Gerrit Updater]

James Nunez ([e-mail]) uploaded a new patch: http://review.whamcloud.com/14021
Subject: LU-5680 tests: Remove all use of /etc from sanity-hsm
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: d6545c1ffb2ded84df550a0e2b810f52f6f4d078

[James Nunez (Inactive)]

Patch http://review.whamcloud.com/14021 replaces all uses of /etc/* with creation of a small file of known size. A second patch will be created to add archiving of zero byte files to sanity-hsm.

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch https://review.whamcloud.com/14021/
Subject: LU-5680 tests: Remove use of /etc/motd from sanity-hsm
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 715c7e9166a34c1f2b781f3314d8b7c02e10950c

[Minh Diep]

Landed for 2.11

[Gerrit Updater]

Minh Diep ([e-mail]) uploaded a new patch: https://review.whamcloud.com/30795
Subject: LU-5680 tests: Remove use of /etc/motd from sanity-hsm
Project: fs/lustre-release
Branch: b2_10
Current Patch Set: 1
Commit: 05b19b2fe88732e36694ce738a915ccd5c0506f5

[Quentin Bouget]

There are still a lot of place in sanity-hsm where /etc/{passwd,hosts} are used. Maybe this ticket should be reopened.

[Gerrit Updater]

John L. Hammond ([e-mail]) merged in patch https://review.whamcloud.com/30795/
Subject: LU-5680 tests: Remove use of /etc/motd from sanity-hsm
Project: fs/lustre-release
Branch: b2_10
Current Patch Set:
Commit: 158b6382704947c0d23d5b79d2b94bdc7a04af10

[James Nunez (Inactive)]

Reopening ticket to allow for patches to replace all uses of /etc files.

[James A Simmons]

Anyone looking at this ?

[James A Simmons]

Doesn't seem to be of interest to anyone anymore. If it is feel free to reopen.

[John Hammond]

Change 14021 - Merged

LU-5680 tests: Remove use of /etc/motd from sanity-hsm

In sanity-hsm tests, /etc/motd is copied to the file system
and archived. /etc/motd may not exist in some Linux distributions
and, if exists, may be of size 0 and may defeat the use of
bandwidth control for timing. Uses of /etc/motd are replaced
with a generated file of known suitable size.

Test-Parameters: trivial testlist=sanity-hsm

Signed-off-by: James Nunez <[e-mail]>
Change-Id: I2f287db6d422ce20bca037ca69e24179c7e48144
Reviewed-on: https://review.whamcloud.com/14021
Reviewed-by: Quentin Bouget <[e-mail]>
Tested-by: Jenkins
Tested-by: Maloo <[e-mail]>
Reviewed-by: John L. Hammond <[e-mail]>
Reviewed-by: Oleg Drokin <[e-mail]>