[LU-5791] LFSCK 5: use bottom object for consistency verification Created: 23/Oct/14  Updated: 23/Feb/15  Resolved: 21/Feb/15

Status: Resolved
Project: Lustre
Component/s: None
Affects Version/s: Lustre 2.7.0
Fix Version/s: Lustre 2.7.0

Type: Bug Priority: Blocker
Reporter: nasf (Inactive) Assignee: nasf (Inactive)
Resolution: Fixed Votes: 0
Labels: None

Issue Links:
Related
is related to LU-6272 sanity-lfsck test_17: MDS deadlock Resolved
is related to LU-6138 lfsck_namespace not progressing and l... Resolved
Severity: 3
Rank (Obsolete): 16255

 Description   

When the LFSCK engine scans the system, it locate the object via the found FID against the low layer device that sometimes is bottom device (OSD/OSP) and sometimes is LOD. So the object handled by LFSCK sometimes is OSD-object/OSP-objecgt and sometimes is LOD-object. Such non-unity may bring trouble to some LFSCK functions. The desirable case is that all the LFSCK functions only handle bottom objects (OSD-object for local, OSP-object for remote).

Please refer to http://review.whamcloud.com/#/c/11845/6/lustre/osd-ldiskfs/osd_handler.c,cm for more discussion.



 Comments   
Comment by Di Wang [ 08/Jan/15 ]

Unfortunately, this has to be fixed first. Because this will conflict with thandle layer patch (http://review.whamcloud.com/#/c/10640/), which is the first patch of DNE2 series. Without this fix, we can not even land any DNE patches, i.e. LFSCK will be broken because of this.

So could you please fix this first, i.e. as your priority ticket. Thank you.

Comment by Gerrit Updater [ 14/Jan/15 ]

Fan Yong (fan.yong@intel.com) uploaded a new patch: http://review.whamcloud.com/13392
Subject: LU-5791 lfsck: use bottom device to locate object
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 1bc16a18387e0efda8e61b08d7fdbca28691a075

Comment by nasf (Inactive) [ 14/Jan/15 ]

To be not block DNE2, this patch needs to be handled with high priority.

Di, do you need this patch to be landed before b2_7 released or not?

Comment by Di Wang [ 20/Jan/15 ]

Nasf: It is not necessarily on 2.7, and I only need it to be landed before landing DNE2 patches.

Comment by nasf (Inactive) [ 19/Feb/15 ]

We need this patch to resolve some memory leak issues caused by the LFSCK.

Comment by Gerrit Updater [ 21/Feb/15 ]

Oleg Drokin (oleg.drokin@intel.com) merged in patch http://review.whamcloud.com/13392/
Subject: LU-5791 lfsck: use bottom device to locate object
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: f6d744d259fe6bc0b8750127565fb13fb2e66c06

Comment by nasf (Inactive) [ 21/Feb/15 ]

The patch has been landed to master.

Generated at Sat Feb 10 01:54:33 UTC 2024 using Jira 9.4.14#940014-sha1:734e6822bbf0d45eff9af51f82432957f73aa32c.