[LU-5817] cl_put_grouplock()) ASSERTION( cg->cg_gid ) failed Created: 28/Oct/14 Updated: 02/Apr/15 Resolved: 22/Jan/15 |
|
| Status: | Resolved |
| Project: | Lustre |
| Component/s: | None |
| Affects Version/s: | Lustre 2.7.0, Lustre 2.5.3 |
| Fix Version/s: | Lustre 2.7.0 |
| Type: | Bug | Priority: | Critical |
| Reporter: | Patrick Farrell (Inactive) | Assignee: | Cliff White (Inactive) |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | MB, patch | ||
| Environment: |
Any 2.x version of Lustre. Client crash. |
||
| Issue Links: |
|
||||||||
| Severity: | 3 | ||||||||
| Rank (Obsolete): | 16316 | ||||||||
| Description |
|
When a group lock with GID=0 is released (put_grouplock is called), an assertion in cl_put_grouplock is hit. There are two assertions at the start of cl_put_grouplock: cg_env is a pointer, so this assertion is valid, but cg_gid is just an integer so this is not a valid assertion. There are no other checks to make sure the GID is not zero, so a zero a GID is otherwise valid. Since there doesn't appear to be any reason a '0' GID shouldn't be allowed, the solution is to remove this assertion. I'll make a patch shortly. |
| Comments |
| Comment by Patrick Farrell (Inactive) [ 28/Oct/14 ] |
| Comment by Oleg Drokin [ 28/Oct/14 ] |
|
The idea was to disallow use of gid 0 at all, so we really should check in the get/put handler not to allow gid of 0 and leave the assertion intact. |
| Comment by Patrick Farrell (Inactive) [ 28/Oct/14 ] |
|
OK - I can make a patch to have the ioctl code return EINVAL if GID is 0, then. |
| Comment by Gerrit Updater [ 19/Nov/14 ] |
|
Oleg Drokin (oleg.drokin@intel.com) merged in patch http://review.whamcloud.com/12459/ |
| Comment by Gerrit Updater [ 24/Nov/14 ] |
|
frank zago (fzago@cray.com) uploaded a new patch: http://review.whamcloud.com/12838 |
| Comment by Frank Zago (Inactive) [ 24/Nov/14 ] |
|
Test for this and other conditions: http://review.whamcloud.com/12838 |
| Comment by Gerrit Updater [ 22/Jan/15 ] |
|
Oleg Drokin (oleg.drokin@intel.com) merged in patch http://review.whamcloud.com/12838/ |
| Comment by Peter Jones [ 22/Jan/15 ] |
|
Landed for 2.7 |
| Comment by Gerrit Updater [ 02/Apr/15 ] |
|
frank zago (fzago@cray.com) uploaded a new patch: http://review.whamcloud.com/14344 |