[LU-5829] too many EXPORT_SYMBOL in code Created: 30/Oct/14  Updated: 02/Aug/16  Resolved: 19/Jul/15

Status: Resolved
Project: Lustre
Component/s: None
Affects Version/s: None
Fix Version/s: Lustre 2.8.0

Type: Bug Priority: Minor
Reporter: Frank Zago (Inactive) Assignee: Cliff White (Inactive)
Resolution: Fixed Votes: 0
Labels: patch

Issue Links:
Related
is related to LU-6215 Sync Lustre external tree with lustre... Resolved
Severity: 3
Rank (Obsolete): 16350

 Description   

Lustre currently exports 1809 symbols, compared to 25395 symbols for the whole linux kernel.

A lot of these symbols don't need to be exported at all because they are only used in the module they belong to.



 Comments   
Comment by Frank Zago (Inactive) [ 30/Oct/14 ]

Removing 565 unnecessary exports: http://review.whamcloud.com/12510

Comment by Gerrit Updater [ 09/Jan/15 ]

frank zago (fzago@cray.com) uploaded a new patch: http://review.whamcloud.com/13319
Subject: LU-5829 libcfs: remove unnecessary EXPORT_SYMBOL
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 3c7c8828b71b306f5c70290ef02623ac3f2dc27b

Comment by Gerrit Updater [ 09/Jan/15 ]

frank zago (fzago@cray.com) uploaded a new patch: http://review.whamcloud.com/13320
Subject: LU-5829 lnet: remove unnecessary EXPORT_SYMBOL
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 520e866feb00c83a79851dc94f5c44141bbba1c0

Comment by Gerrit Updater [ 09/Jan/15 ]

frank zago (fzago@cray.com) uploaded a new patch: http://review.whamcloud.com/13321
Subject: LU-5829 misc: remove unnecessary EXPORT_SYMBOL
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: cd43357fbc0946db233369ed4d38055cecddb9df

Comment by Gerrit Updater [ 09/Jan/15 ]

frank zago (fzago@cray.com) uploaded a new patch: http://review.whamcloud.com/13323
Subject: LU-5829 obdclass: remove unnecessary EXPORT_SYMBOL
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 44dcebf9d1a48b9acea3b09462da0f64080d9b24

Comment by Gerrit Updater [ 09/Jan/15 ]

frank zago (fzago@cray.com) uploaded a new patch: http://review.whamcloud.com/13324
Subject: LU-5829 ldlm: remove unnecessary EXPORT_SYMBOL
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 5f75d00444ab1785e598f962091ca8d849169279

Comment by Gerrit Updater [ 03/Feb/15 ]

Oleg Drokin (oleg.drokin@intel.com) merged in patch http://review.whamcloud.com/13321/
Subject: LU-5829 misc: remove unnecessary EXPORT_SYMBOL
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 34bdd30ec6a2010dfd98c5110487df210d03815d

Comment by Gerrit Updater [ 03/Feb/15 ]

Oleg Drokin (oleg.drokin@intel.com) merged in patch http://review.whamcloud.com/13323/
Subject: LU-5829 obdclass: remove unnecessary EXPORT_SYMBOL
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: adc9384fd11b7fb3b71b363c310c9fa7b37e469f

Comment by Gerrit Updater [ 04/Feb/15 ]

Oleg Drokin (oleg.drokin@intel.com) merged in patch http://review.whamcloud.com/12510/
Subject: LU-5829 ptlrpc: remove unnecessary EXPORT_SYMBOL
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 3ee0e0908f12de97346cd5fe2996ad147adb9481

Comment by Gerrit Updater [ 18/Mar/15 ]

Oleg Drokin (oleg.drokin@intel.com) merged in patch http://review.whamcloud.com/13320/
Subject: LU-5829 lnet: remove unnecessary EXPORT_SYMBOL
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: db841c2218bd184f0b113e99c316b9039194859c

Comment by Gerrit Updater [ 18/Mar/15 ]

Oleg Drokin (oleg.drokin@intel.com) merged in patch http://review.whamcloud.com/13324/
Subject: LU-5829 ldlm: remove unnecessary EXPORT_SYMBOL
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: e536e511c9e634d8cb7faf763ecab4cab5f40267

Comment by James A Simmons [ 15/Jul/15 ]

One patch left that once landed we can close this ticket.

Comment by Gerrit Updater [ 19/Jul/15 ]

Oleg Drokin (oleg.drokin@intel.com) merged in patch http://review.whamcloud.com/13319/
Subject: LU-5829 libcfs: remove unnecessary EXPORT_SYMBOL
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 502c141440b4e6a75a1162d25ba98315abe7ca4e

Comment by Peter Jones [ 19/Jul/15 ]

Landed for 2.8

Comment by Gerrit Updater [ 18/Sep/15 ]

frank zago (fzago@cray.com) uploaded a new patch: http://review.whamcloud.com/16482
Subject: LU-5829 quota: fixed invalid memset
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 4d46ee296e4698f1d699a264d0e209d2fb1ce11d

Comment by Frank Zago (Inactive) [ 18/Sep/15 ]

Incorrect LU in commit. Please ignore that.

Comment by Andrew Perepechko [ 02/Aug/16 ]

frank zago (fzago@cray.com) uploaded a new patch: http://review.whamcloud.com/13323

This patch is not correct. It removes e.g. lu_ref_add() export, but it is used from other modules (you can check with grep).
Builds with --enable-lu_ref are broken because of this change.

Comment by Frank Zago (Inactive) [ 02/Aug/16 ]

Fix for that issue is in LU-8471.

Generated at Sat Feb 10 01:54:53 UTC 2024 using Jira 9.4.14#940014-sha1:734e6822bbf0d45eff9af51f82432957f73aa32c.