[LU-5831] New static analysis issues in lfsck

• Status: Resolved
• Project: Lustre
• Affects Version/s: Lustre 2.7.0
• Fix Version/s: Lustre 2.7.0
• Type: Bug
• Priority: Critical
• Reporter: Dmitry Eremin (Inactive)
• Assignee: nasf (Inactive)
• Resolution: Fixed
• Labels: kw
• Severity: 3

Description

Found 2 new static analysis issues in 2.6.54-45-g8fab48a:

1. Pointer may be dereferenced after it was positively checked for NULL
   • lustre/lfsck/lfsck_engine.c: in lfsck_close_dir, Pointer 'lfsck->li_obj_dir' checked for NULL at line 380 may be dereferenced at line 393.
2. Buffer Overflow - Array Index Out of Bounds
   • lustre/lfsck/lfsck_namespace.c: in lfsck_namespace_in_notify, Array 'lr.lr_pool_name' of size 15 may use index value(s) 15

     char lmv_pool_name[LOV_MAXPOOLNAME + 1];
     ...
     char lr_pool_name[LOV_MAXPOOLNAME];
     ...
     memcpy(lmv->lmv_pool_name, lr->lr_pool_name, sizeof(lmv->lmv_pool_name));
     

The list of commits since the previous build 2.6.54-29-g7e41c11:

8fab48a	LU-5568 lnet: fix kernel crash when network failed to start
0a18a6a	LU-5756 hsm: add missing return code in llapi_hsm_copytool_register
bc23995	LU-5743 build: Update to zfs/spl 0.6.3-1.1
85ba174	LU-5641 tests: ensure user daemon is in group bin
9849f61	LU-5287 export: hold exp_lock when modify exp_flags
acdaca8	LU-5674 test: print spl debug info
b5e911f	LU-4942 at: per-export lock callback timeout
38ec486	LU-5626 ldiskfs: update non-htree dotdot in rename
8e3d8b7	LU-5675 quota: correctly set II_FL_NONUNQ in dt_index_read()
2e38757	LU-5519 lfsck: LFSCK code framework adjustment (2)
ad6dd12	LU-5518 lfsck: recover orphans from backend lost+found
9ff2d95	LU-5517 lfsck: repair invalid nlink count
e881286	LU-5727 ldlm: revert changes to ldlm_cancel_aged_policy()
e0d08c0	LU-5777 quota: reserve enough credits for setattr
72ae278	LU-5606 tests: add version check codes to conf-sanity test 41c
0f22e4c	LU-1996 lustre: Flexible changelog format.

Issue Links

• is related to: LU-4629 Issues found by static analysis tools
• is related to: LU-2753 Tracking bug for static code analysis...

Comments

[nasf (Inactive)]

Here is the patch for LFSCK:
http://review.whamcloud.com/#/c/12534/

[nasf (Inactive)]

The patch has been landed to master.