[LU-5837] ll_getparent improvements

• Status: Resolved
• Project: Lustre
• Fix Version/s: Lustre 2.7.0
• Type: Bug
• Priority: Minor
• Reporter: Henri Doreau (Inactive)
• Assignee: John Hammond
• Resolution: Fixed
• Labels: patch
• Severity: 3

Description

Reviewers have made several suggestions on LU-3613 which, though not critical, should be addressed for the sake of code quality & efficiency.

Issue Links

• is related to: LU-5870 New static analysis issues in llite
• is related to: LU-3613 Get parent_fid + name for an entry

Comments

[Henri Doreau (Inactive)]

Initial comments were made on: http://review.whamcloud.com/7069

Patch addressing the issues: http://review.whamcloud.com/12527

[Peter Jones]

John

Could you please review Henri's latest changes?

Thanks

Peter

[Frank Zago (Inactive)]

0001-LU-5837-llite-create-linkea_seek_entry-and-use-it-in.patch

[Henri Doreau (Inactive)]

So, I've tried to integrate your patch (see patchset #3). I think it adds some complexity (a third function to maintain, with duplicated logic) without bringing much since it's still required to iterate over the variable records to get the N-th entry. I tend to prefer patchset #2.

[Gerrit Updater]

Henri Doreau ([e-mail]) uploaded a new patch: http://review.whamcloud.com/12527
Subject: LU-5837 llite: ll_getparent cleanup
Project: fs/lustre-release
Branch: master
Current Patch Set: 5
Commit: 749fec00ae1ca47135b7b5cedaf911b9420c2056

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch http://review.whamcloud.com/12527/
Subject: LU-5837 llite: ll_getparent cleanup
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 188325f9211b6f2b87a04ec1155b005b8af54c2b

[Peter Jones]

Landed for 2.7