[LU-5840] Should Null pointer occurrence in mdc_unpack_acl throw a warning

• Status: Resolved
• Project: Lustre
• Affects Version/s: Lustre 2.6.0, Lustre 2.5.3
• Type: Bug
• Priority: Minor
• Reporter: Roland Fehrenbacher
• Assignee: WC Triage
• Resolution: Cannot Reproduce

Environment

At least ZFS based MGS/MDS/OSS

• Severity: 3

Description

A possible null pointer dereference in mdc_unpack_acl was reported and fixed in LU-4787 / LU-5150. While the patch in LU-5150 just prevents the dereference, the patch in LU-4787 in addition throws a warning. As explained in LU-5150, I have indications that this NULL pointer occurence can indicate some FS corruption and is thus worthwhile to notice. Working with the patch in LU-4787 for more than half a year now, judging from our experience on multiple clusters, the issue occurs rarely (actually just on one cluster so far) so I don't see a danger of log flooding.
I therefore propose to use the patch in LU-4787.

Comments

[Peter Jones]

Roland

Can you push the patch to gerrit so we can test and review it?

Peter