[LU-5849] DLC: parse networks function needs to return the number of parsed networks

• Status: Resolved
• Project: Lustre
• Affects Version/s: Lustre 2.7.0
• Fix Version/s: Lustre 2.7.0
• Type: Bug
• Priority: Critical
• Reporter: Amir Shehata (Inactive)
• Assignee: Amir Shehata (Inactive)
• Resolution: Fixed
• Labels: MB
• Severity: 3

Description

lnet_dyn_add_ni() requires lnet_parse_networks() to return the number of nets (outside of LO) that were parsed in order to do proper sanity checks. Currently it returns < 0 for failure and 0 for failure.

Issue Links

• is related to: LU-5734 LNet dynamic control: lnet_dyn_add_ni...
• is related to: LU-2456 Dynamic LNet Config Main Development ...

Comments

[Amir Shehata (Inactive)]

http://review.whamcloud.com/#/c/12537/

[Isaac Huang (Inactive)]

I think it's good chance now to clean up lnet_parse_networks(). It used to add a LO by itself only because it made sense to its only caller LNetNIInit(). Now the added LO can actually cause trouble to the new caller lnet_dyn_add_ni(), which doesn't want that LO at all.

I think:
1. lnet_parse_networks() should NOT add LO
2. LNetNIInit() adds LO to the parsed NI list if lnet_parse_networks() returned OK.
3. lnet_dyn_add_ni() now doesn't need to do anything special about the extra LO.

[James A Simmons]

Has this been resolved due to the landing of LU-5374?