[LU-5870] New static analysis issues in llite

• Status: Resolved
• Project: Lustre
• Fix Version/s: Lustre 2.7.0
• Type: Bug
• Priority: Minor
• Reporter: Dmitry Eremin (Inactive)
• Assignee: WC Triage
• Resolution: Fixed
• Labels: kw
• Severity: 3

Description

After commit b6e3612d845cf506e977f49aa85ddd1e709fd194 the 'ln.ln_name' and 'ln.ln_namelen' might be used uninitialized in this function.

TRACEBACK:

• llite_lib.c:2823: 'ln.ln_namelen' is declared.
• llite_lib.c:2837: Not entering loop, because ldata->ld_lee!= ( (void* )0) is false
• llite_lib.c:2850: 'ln.ln_namelen' is used, but is uninitialized.
• llite_lib.c:2854: 'ln.ln_name' is used, but is uninitialized.

Issue Links

• is related to: LU-4629 Issues found by static analysis tools
• is related to: LU-5837 ll_getparent improvements

Comments

[Andreas Dilger]

This code was added in the "LU-3613 llite: Add ioctl to get parent fids from link EA" patch. Thomas or Henri, could you please provide a patch?

[Henri Doreau (Inactive)]

There's already a patch aiming at cleaning up this code (for other reasons). It is tracked as LU-5837 and is currently being reviewed at http://review.whamcloud.com/#/c/12527/. The reported pattern has been replaced by something cleaner.

This said, it looks like a false positive to me. Provided ldata is consistent, the idx/linkno checks should prevent from using ln uninitialized.

[Jodi Levi (Inactive)]

Patch landed to Master.