[LU-5973] bad error message in ofd_destroy() Created: 03/Dec/14  Updated: 23/Nov/16  Resolved: 26/Feb/15

Status: Resolved
Project: Lustre
Component/s: None
Affects Version/s: Lustre 2.5.3
Fix Version/s: Lustre 2.5.4

Type: Bug Priority: Minor
Reporter: Bob Glossman (Inactive) Assignee: Bob Glossman (Inactive)
Resolution: Fixed Votes: 0
Labels: None

Issue Links:
Duplicate
is duplicated by LU-6276 LustreError: error destroying object Closed
Related
Severity: 3
Rank (Obsolete): 16682

 Description   

First noticed when examining error logs for a different problem. The following code fragment prints the wrong value in the error log:

                } else if (lrc != 0) {
                        CERROR("%s: error destroying object "DFID": %d\n",
                               ofd_obd(ofd)->obd_name, PFID(&info->fti_fid),
                               rc);
                        rc = lrc;
                }

It should be printing the lrc, not rc. As is the logged message is not as useful as it could be.

Will enter a patch to correct this.



 Comments   
Comment by Gerrit Updater [ 03/Dec/14 ]

Bob Glossman (bob.glossman@intel.com) uploaded a new patch: http://review.whamcloud.com/12921
Subject: LU-5973 ofd: fix bad error message
Project: fs/lustre-release
Branch: b2_5
Current Patch Set: 1
Commit: bd94f11f5f34f8da24c0bd3e1bfdcedc13e099f3

Comment by Andreas Dilger [ 03/Dec/14 ]

Does this not affect master?

Comment by Bob Glossman (Inactive) [ 03/Dec/14 ]

no, the equivalent error message in master is already correct. It's a b2_5 only problem.

Comment by Gerrit Updater [ 25/Feb/15 ]

Oleg Drokin (oleg.drokin@intel.com) merged in patch http://review.whamcloud.com/12921/
Subject: LU-5973 ofd: fix bad error message
Project: fs/lustre-release
Branch: b2_5
Current Patch Set:
Commit: cae87fca0a1656487786186e8c96ffdac2e3e45a

Comment by Peter Jones [ 26/Feb/15 ]

Landed for 2.5.4

Generated at Sat Feb 10 01:56:07 UTC 2024 using Jira 9.4.14#940014-sha1:734e6822bbf0d45eff9af51f82432957f73aa32c.