[LU-5975] Consider removing quotacheck compatibility code

• Status: Resolved
• Project: Lustre
• Affects Version/s: Lustre 2.8.0
• Fix Version/s: Lustre 2.8.0
• Type: Bug
• Priority: Blocker
• Reporter: James Nunez (Inactive)
• Assignee: Niu Yawei (Inactive)
• Resolution: Fixed
• Labels: quota
• Severity: 3

Description

Current versions of Lustre define cl_qchk_stat in the client_obd struct and is used by quotacheck with servers older than 2.4. In Lustre 2.8, tag 2.7.53 and above, a warning is printed to “please consider removing quotacheck compatibility code”. This comes from the following code in lustre/include/obd.h in the definition of the client_obd struct:

…
	/* used by quotacheck when the servers are older than 2.4 */
	int                      cl_qchk_stat; /* quotacheck stat of the peer */
#define CL_NOT_QUOTACHECKED 1   /* client->cl_qchk_stat init value */
#if LUSTRE_VERSION_CODE >= OBD_OCD_VERSION(2, 7, 53, 0)
#warning "please consider removing quotacheck compatibility code"
#endif
…

Thus, we should consider removing quotacheck compatibility code.

Issue Links

• is related to: LU-6617 Remove quota migration code
• is related to: LU-1842 Quota enforcement landing
• is related to: LU-6568 error: #warning "please consider remo...

Comments

[Gerrit Updater]

Niu Yawei ([e-mail]) uploaded a new patch: http://review.whamcloud.com/14705
Subject: LU-5975 quota: remove obsolete quota code
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: cda963b50ed34529846ed445b7e4dde1519e6e86

[Richard Henwood (Inactive)]

We all love tags, and this issue is apparently blocking the creation of one now

[Oleg Drokin]

This patch is not enough to address the issue, I am still gettign an error in osd-ldiskfs:

/home/green/git/lustre-release/lustre/osd-ldiskfs/osd_quota_fmt.c:87:2: error: #warning "remove old quota compatibility code"

[Niu Yawei (Inactive)]

Yes, I missed this one. It's used for migrating on-disk old quota adim files into new format. As long as we support upgrading 2.1 system into 2.8, these code should be kept, otherwise, they can be removed. I will cleanup them in another patch.

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch http://review.whamcloud.com/14705/
Subject: LU-5975 quota: remove obsolete quota code
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 1738e70fe6aaf1e07b78a6b89eb11ea115135e69

[Peter Jones]

Niu

I think that it is ok to remove the capability to upgrade directly from such an old release - anyone needing to make such a jump could upgrade to an intermediate release first

Peter

[Niu Yawei (Inactive)]

Ok, I'll fix it in another ticket. Thanks.

[Peter Jones]

Landed in 2.8