[LU-5977] Remove correction for bad timestamp Created: 03/Dec/14  Updated: 03/Sep/15  Resolved: 03/Sep/15

Status: Resolved
Project: Lustre
Component/s: None
Affects Version/s: Lustre 2.8.0
Fix Version/s: Lustre 2.8.0

Type: Bug Priority: Minor
Reporter: James Nunez (Inactive) Assignee: Bob Glossman (Inactive)
Resolution: Fixed Votes: 0
Labels: easy, patch

Issue Links:
Related
is related to LU-221 sanityN.sh test_4 failed Resolved
is related to LU-1042 1.8 clients show wrong dates with 2.1... Resolved
Severity: 3
Rank (Obsolete): 16690

 Description   

There was a bug in Lustre 2.1.0 that caused negative timestamps. In Lustre 2.8, tag 2.7.53 and above, code to correct for bad timestamps in Lustre 2.1.0 will no longer be used.
If we want to continue correcting for negative time stamps, the following code must be modified else it can be removed:

In lustre/include/dt_object.h:

#define LU221_BAD_TIME (0x80000000U + 24 * 3600)

In lustre/ofd/ofd_objects.c routine ofd_attr_get(),

#if LUSTRE_VERSION_CODE < OBD_OCD_VERSION(2, 7, 53, 0)
		/* Try to correct for a bug in 2.1.0 (LU-221) that caused
		 * negative timestamps to appear to be in the far future,
		 * due old timestamp being stored on disk as an unsigned value.
		 * This fixes up any bad values stored on disk before
		 * returning them to the client, and ensures any timestamp
		 * updates are correct.  LU-1042 */
		if (unlikely(la->la_atime == LU221_BAD_TIME))
			la->la_atime = 0;
		if (unlikely(la->la_mtime == LU221_BAD_TIME))
			la->la_mtime = 0;
		if (unlikely(la->la_ctime == LU221_BAD_TIME))
			la->la_ctime = 0;
#endif


 Comments   
Comment by Gerrit Updater [ 25/Aug/15 ]

Giuseppe Di Natale (dinatale2@llnl.gov) uploaded a new patch: http://review.whamcloud.com/16077
Subject: LU-5977 ofd: Removed correction for bad timestamps
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: b457311ab040748765a38e22eb4fff4523076418

Comment by Gerrit Updater [ 03/Sep/15 ]

Oleg Drokin (oleg.drokin@intel.com) merged in patch http://review.whamcloud.com/16077/
Subject: LU-5977 ofd: Removed correction for bad timestamps
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: aa7c70a7d6f0720e82afce267415e740b23f00ec

Comment by Joseph Gmitter (Inactive) [ 03/Sep/15 ]

Landed for 2.8.

Generated at Sat Feb 10 01:56:09 UTC 2024 using Jira 9.4.14#940014-sha1:734e6822bbf0d45eff9af51f82432957f73aa32c.