[LU-5979] RPC size compatibility code

• Status: Resolved
• Project: Lustre
• Affects Version/s: Lustre 2.8.0
• Fix Version/s: Lustre 2.8.0
• Type: Bug
• Priority: Minor
• Reporter: James Nunez (Inactive)
• Assignee: Nathaniel Clark
• Resolution: Fixed
• Severity: 3

Description

From Lustre code comments:

For interoperability with 1.8 and 2.0 clients/servers. The RPC verification code allows larger RPC buffers, but not smaller buffers. Until we no longer need to keep compatibility with older servers/clients we can only check that the buffer size is at least as large as obd_connect_data_v1. That is not in itself harmful, since the chance of just corrupting this field is low. See JIRA LU-16 for details.

In Lustre 2.8, tag 2.7.53 and above, this RPC size compatibility is no longer maintained. If we want to maintain the RPC size compatibility, the following code should be modified else it should be removed:

In file lustre/ptlrpc/layout.c, the definition of the RMF_CONNECT_DATA struct contains:

#if LUSTRE_VERSION_CODE > OBD_OCD_VERSION(2, 7, 53, 0)
		    sizeof(struct obd_connect_data),
#else
/* For interoperability with 1.8 and 2.0 clients/servers.
* The RPC verification code allows larger RPC buffers, but not
* smaller buffers.  Until we no longer need to keep compatibility
* with older servers/clients we can only check that the buffer
* size is at least as large as obd_connect_data_v1.  That is not
* not in itself harmful, since the chance of just corrupting this
* field is low.  See JIRA LU-16 for details. */
		    sizeof(struct obd_connect_data_v1),
#endif

Issue Links

• is related to: LU-16 Allow objects larger than 2TB in size

Comments

[Peter Jones]

Is this still an issue? Or has the moment passed where this would still be beneficial?

[Nathaniel Clark]

This was fixed prior to 2.7.52.

The code in question was removed by:
http://review.whamcloud.com/13960
Commit: 807a40c5678109087e2c8759bd86253034804c8d