[LU-5991] memory leak on mount failure Created: 05/Dec/14  Updated: 06/Mar/18  Resolved: 06/Mar/18

Status: Resolved
Project: Lustre
Component/s: None
Affects Version/s: None
Fix Version/s: Lustre 2.11.0

Type: Bug Priority: Trivial
Reporter: Vladimir V. Saveliev Assignee: WC Triage
Resolution: Fixed Votes: 0
Labels: patch

Severity: 4
Rank (Obsolete): 16713

 Description   

lustre_fill_super() allocates lsi and assumes that in case of failures server_fill_super() or ll_fill_super() will call server_put_super()/ll_put_super() to free the lsi. However,

  • server_fill_super() misses that when lsi_prepare() fails.
  • ll_fill_super() misses that when OBD_ALLOC_PTR(cfg) or
    ll_init_sbi() fail.

 Comments   
Comment by Gerrit Updater [ 05/Dec/14 ]

Vladimir Saveliev (vladimir_saveliev@xyratex.com) uploaded a new patch: http://review.whamcloud.com/12959
Subject: LU-5991 obd: fix mount error handing
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: ba9ca8da39d382cca9a4754dbbe04fe30aeb1143

Comment by Vladimir Saveliev [ 18/May/15 ]

The patch is updated to address style warning:
http://review.whamcloud.com/#/c/12959/

Comment by Gerrit Updater [ 06/Mar/18 ]

Oleg Drokin (oleg.drokin@intel.com) merged in patch https://review.whamcloud.com/12959/
Subject: LU-5991 obd: fix mount error handing
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: acabfb9594c956081b615d22cfc1bd39e8a3f331

Comment by Peter Jones [ 06/Mar/18 ]

Landed for 2.11

Generated at Sat Feb 10 01:56:16 UTC 2024 using Jira 9.4.14#940014-sha1:734e6822bbf0d45eff9af51f82432957f73aa32c.