[LU-6030] cleanup for ldiskfs patches

• Status: Resolved
• Project: Lustre
• Fix Version/s: Lustre 2.8.0
• Type: Improvement
• Priority: Minor
• Reporter: Yang Sheng
• Assignee: Yang Sheng
• Resolution: Fixed

Description

Some ldiskfs patch need cleanup. From comments in http://review.whamcloud.com/#/c/10249/21 and http://review.whamcloud.com/#/c/10249/27:

• ext4-extents-mount-option.patch: We format the OST with the EXT4_FEATURE_INCOMPAT_EXTENTS, and avoid it for the MDT. At most we would need to have a dummy mount option that accepts the "-o extents" option from Lustre (to avoid LU-5425), and returns an error at mount time if INCOMPAT_EXTENTS is not already set. It would be possible to delete the whole patch by removing the "extents" option from the mount options in osd_mount()
• ext4-misc.patch: It would be possible to remove the stub "mballoc", "iopen", "noiopen", "iopen_nopriv" mount option handling by removing those strings from the mount options in osd_mount()
• ext4-fiemap.patch: this patch can be removed entirely, even from older RHEL6 kernels. ext4_fiemap() is accessible via ext4_file_inode_operations, so we could just call inode->i_op->fiemap(), and move the rest of the code into osd-ldiskfs/osd-fiemap.c
• ext4-nocmtime.patch: this could be simplified by changing only ext4_current_time(inode) to return inode->i_ctime if NOCMTIME is set on the inode
• ext4-pdirops.patch: it would be nice to split this into two separate patches. One for implementing 3-level htree and EXT4_FEATURE_INCOMPAT_LARGEDIR, and the other for pdirops. The 3-level htree LARGEDIR feature might be accepted upstream, while pdirops/htree_lock is harder since it has no VFS interface
• ext4-pdirops.patch: remove i_append_sem and use i_data_sem or xattr_sem (if possible, not sure if there would be deadlocks in some code path)
• ext4-max-dir-size.patch: add deprecation warning for max_dir_size /sysfs entry if used

Issue Links

• is related to: LU-5424 Test failuresanity test_154b: create ...
• is related to: LU-6215 Sync Lustre external tree with lustre...
• is related to: LU-6978 mkfs.lustre: LDISKFS-fs (loop0): Unre...
• is related to: LU-6201 remove duplicate fiemap code/defines
• is related to: LU-6220 push ext4/ldiskfs patches upstream if...
• is related to: LU-896 change e2fsprogs to make it allow dir...
• is related to: LU-6141 Merge ldiskfs patches into upstream e...

Comments

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch http://review.whamcloud.com/13067/
Subject: LU-6030 ldiskfs: cleanup ldiskfs_journal_dirty_metadata
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 30f9697637c09e593bfbbc8ccbc7993ccfdeac36

[Gerrit Updater]

Yang Sheng ([e-mail]) uploaded a new patch: http://review.whamcloud.com/13283
Subject: LU-6030 ldiskfs: remove cond_sched patch
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 4ee065f087a4af06d3e96f8c3ef1dd926fdfc38d

[Gerrit Updater]

Yang Sheng ([e-mail]) uploaded a new patch: http://review.whamcloud.com/13571
Subject: LU-6030 ldiskfs: clean up ext4-fiemap patch
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 2fb1a61bb544647fc23e73d59391abec1b9be461

[Gerrit Updater]

Yang Sheng ([e-mail]) uploaded a new patch: http://review.whamcloud.com/13572
Subject: LU-6030 ldiskfs: simplify extents-mount-option patch
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 9d1164420dcf7647405a16e3335dae35d4fb8e9e

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch http://review.whamcloud.com/13571/
Subject: LU-6030 ldiskfs: clean up ext4-fiemap patch
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 98b03592d1d0c70ab4bf96daf9778b8ffc2b74d1

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch http://review.whamcloud.com/13572/
Subject: LU-6030 osd-ldiskfs: improve mount option handling
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 61d4357fa8c0c6371e3ab66a9d38aaa6cc7bf4d8

[James A Simmons]

Is their any work left for this?

[Jian Yu]

Yang Sheng ([e-mail]) uploaded a new patch: http://review.whamcloud.com/13283
Subject: LU-6030 ldiskfs: remove cond_sched patch
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 4ee065f087a4af06d3e96f8c3ef1dd926fdfc38d

The above patch is left. Others have landed to master.

[Yang Sheng]

There have a few patches still under test.

[Gerrit Updater]

Yang Sheng ([e-mail]) uploaded a new patch: http://review.whamcloud.com/14264
Subject: LU-6030 ldiskfs: split pdirop patch
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: fd16a2ce5f210518378e0be14f312d7a37db4bc1

[Gerrit Updater]

Yang Sheng ([e-mail]) uploaded a new patch: http://review.whamcloud.com/14299
Subject: LU-6030 ldiskfs: Remove alloc-policy patch
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 812c9846c9b3625fdf72762869f3d687162adc1f

[Gerrit Updater]

Yang Sheng ([e-mail]) uploaded a new patch: http://review.whamcloud.com/14490
Subject: LU-6030 ldiskfs: further cleanup patches of ldiskfs
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: e82739c11d71a8003ef41c83171da34c9ed77dc6

[Gerrit Updater]

Yang Sheng ([e-mail]) uploaded a new patch: http://review.whamcloud.com/14910
Subject: LU-6030 ldiskfs: Remove alloc-policy patch
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 75b029d8b52a11db4238c2dab36d76a9396a1988

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch http://review.whamcloud.com/14299/
Subject: LU-6030 ldiskfs: Remove alloc-policy patch
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 0932c4e400be315bf608a553d3ad2463e7923d4a

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch http://review.whamcloud.com/14264/
Subject: LU-6030 ldiskfs: split pdirop patch
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 953e97987426bcc43a74be5b14f3a71319b33825

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch http://review.whamcloud.com/14490/
Subject: LU-6030 ldiskfs: further cleanup patches of ldiskfs
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: f0756c16892e854e58d06627252d390c91ef5f94

[James A Simmons]

The patch that split pdirops breaks ldiskfs for RHEL6.5

[Gerrit Updater]

James Simmons ([e-mail]) uploaded a new patch: http://review.whamcloud.com/15196
Subject: LU-6030 ldiskfs: support pdirop split for RHEL6.5
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: d5ac1fe260e5108abe2f1121a1ea9e94f858678a

[Gerrit Updater]

Andreas Dilger ([e-mail]) merged in patch http://review.whamcloud.com/15196/
Subject: LU-6030 ldiskfs: support pdirop split for RHEL6.5
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 4c25ec609bc2ecc31d014689c2498c4df60dddd2

[Yang Sheng]

Patches landed. So close this ticket.