[LU-6055] sanity-hsm file_creation_failure sends df output to stdout Created: 19/Dec/14 Updated: 20/Feb/15 Resolved: 29/Dec/14 |
|
| Status: | Resolved |
| Project: | Lustre |
| Component/s: | None |
| Affects Version/s: | Lustre 2.7.0 |
| Fix Version/s: | Lustre 2.7.0 |
| Type: | Bug | Priority: | Blocker |
| Reporter: | John Hammond | Assignee: | John Hammond |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | hsm, test | ||
| Issue Links: |
|
||||||||
| Severity: | 3 | ||||||||
| Rank (Obsolete): | 16867 | ||||||||
| Description |
|
The file_creation_failure() function added to sanity-hsm calls df for debugging purposes but does not redirect the output of df to stderr. Since file_creation_failure is used in functions like make_large_for_cancel which are in turn used in command substitution local f=$(make_large_for_cancel ...) the df output goes into $f. Also many of these functions check for success by calling path2fid which pipes lfs to tr path2fid() {
$LFS path2fid $1 | tr -d '[]'
}
Since tr will succeed this will fail to detect errors. |
| Comments |
| Comment by Gerrit Updater [ 19/Dec/14 ] |
|
John L. Hammond (john.hammond@intel.com) uploaded a new patch: http://review.whamcloud.com/13154 |
| Comment by Andreas Dilger [ 19/Dec/14 ] |
|
It looks like this was introduced by http://review.whamcloud.com/12456 landing. |
| Comment by Gerrit Updater [ 26/Dec/14 ] |
|
Oleg Drokin (oleg.drokin@intel.com) merged in patch http://review.whamcloud.com/13154/ |
| Comment by Jodi Levi (Inactive) [ 29/Dec/14 ] |
|
Patch landed to Master. |
| Comment by Gerrit Updater [ 20/Feb/15 ] |
|
James Nunez (james.a.nunez@intel.com) uploaded a new patch: http://review.whamcloud.com/13827 |