[LU-6073] lustre/tests/*.c should use sys/xattr.h rather than attr/xattr.h

• Status: Resolved
• Project: Lustre
• Affects Version/s: Lustre 2.7.0
• Fix Version/s: Lustre 2.7.0, Lustre 2.8.0
• Type: Bug
• Priority: Minor
• Reporter: John Hammond
• Assignee: John Hammond
• Resolution: Fixed
• Severity: 3

Description

In lustre/tests/

{multiop,orphan_linkea_check}

.c we should include sys/xattr.h (provided by glibc-headers) rather than attr/xattr.h (provided by libattr-devel) since the former is more likely to be installed and has all of the needed declarations.

Issue Links

• is related to: LU-6027 Issues with EAs of orphan files and E...

Comments

[James A Simmons]

Just ran into this issue.

[Bob Glossman (Inactive)]

Just as a data point I had builds fail on several of my long time builder VMs due to this issue. I had not installed the libattr-devel rpms everywhere which contains the /usr/include/attr files. They were never needed before the mod using <attr/xattr.h> landed in master. While the problem went away as soon as I did install the additional rpm I agree that it would be preferable to use the more commonly available <sys/xattr.h> instead.

[Gerrit Updater]

John L. Hammond ([e-mail]) uploaded a new patch: http://review.whamcloud.com/13197
Subject: LU-6073 tests: use sys/xattr.h in tests/*.c
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 2c3b572d3e2d2499189fdf17bb9c51d519193b28

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch http://review.whamcloud.com/13197/
Subject: LU-6073 tests: use sys/xattr.h in tests/*.c
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 9c2e4c1075a66e8576d2fa9bed2c771a1c206fde

[John Hammond]

Patch landed to master.

[Jodi Levi (Inactive)]

Reopening to add fix version

[Gerrit Updater]

John L. Hammond ([e-mail]) uploaded a new patch: http://review.whamcloud.com/15391
Subject: LU-6073 tests: use sys/xattr.h in tests/mpi/*.c
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: dd687d03f0ded47fc1e715d047a48898ea0a90c6

[Gerrit Updater]

John L. Hammond ([e-mail]) uploaded a new patch: http://review.whamcloud.com/15392
Subject: LU-6073 build: add -Wall to CFLAGS for test/ and utils/
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: e6c9e5d829ede1a8a114da73f945cf3bdf10b7b1

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch http://review.whamcloud.com/15391/
Subject: LU-6073 tests: use sys/xattr.h in tests/mpi/*.c
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 1178a9f7dc53b8ecfc5b76c494c8156bc039f4be

[Chris Horn]

The patch at http://review.whamcloud.com/15392 resolves the issue reported in LU-6835, as well as another issue which I did not have time to create a ticket for. Repeating some information here so it can be found via search. Some implicit declarations were introduced by http://review.whamcloud.com/15217 (a801262) in libiam.c and lfs.c

[  280s] cc1: warnings being treated as errors
[  280s] lfs.c: In function 'migrate_copy_timestamps':
[  280s] lfs.c:481: error: implicit declaration of function 'futimes'

and

[  175s] cc1: warnings being treated as errors
[  175s] libiam.c: In function 'lfix_root':
[  175s] libiam.c:155: error: implicit declaration of function 'cpu_to_le64'
[  175s] libiam.c:156: error: implicit declaration of function 'cpu_to_le16'
[  175s] libiam.c:187: error: implicit declaration of function 'cpu_to_le32'

[Chris Horn]

As an aside, it seems like bad practice to re-use a ticket like this, as well as piggy back the "#include" changes on http://review.whamcloud.com/15392