[#LU-608] port 24487 (sgpdd-survey.sh/sgpdd-survey doesn't play nice with devices specified by alias)

[LU-608] port 24487 (sgpdd-survey.sh/sgpdd-survey doesn't play nice with devices specified by alias) Created: 19/Aug/11 Updated: 11/Oct/11 Resolved: 26/Aug/11
Status:	Resolved
Project:	Lustre
Component/s:	None
Affects Version/s:	Lustre 2.1.0, Lustre 1.8.6
Fix Version/s:	Lustre 1.8.7

Type:

Bug

Priority:

Minor

Reporter:

Niu Yawei (Inactive)

Assignee:

Niu Yawei (Inactive)

Resolution:

Duplicate

Votes:

Labels:

None

Attachments:

bz24487.patch

Severity:

Bugzilla ID:

24,487

Rank (Obsolete):

6566

Description

For our acceptance-small configuration we specify devices by-id instead of device name since the
device name occasionally changes. This causes a problem with sgpdd-survey.sh since sgpdd-survey
doesn't translate the alias to the device name.

== test 1: sgpdd-survey, mds, scsidevs == 15:30:35 (1301603435)
Loading modules from
/opt/cray/lustre-cray_gem_s/1.8.4_2.6.32.27_0.2.2_1.0000.5785.16.1-1.0000.25970.22.205/lib64/lustre
lnet.debug=-1
lnet.subsystem_debug=0xffb7e3ff
lnet options: ' accept=all'
=== mds === nid00035 === /dev/disk/by-id/scsi-3600a0b80005121d800001f7a4cd16b41-part1 ===
nid00035: + rslt=/tmp/sgpdd_survey size=1024 crghi=2 thrhi=2
scsidevs="/dev/disk/by-id/scsi-3600a0b80005121d800001f7a4cd16b41-part1"
/opt/cray/lustre-cray_gem_s/1.8.4_2.6.32.27_0.2.2_1.0000.5785.16.1-1.0000.25970.22.205/bin/sgpdd-survey
nid00035: Can't find SG device for /dev/disk/by-id/scsi-3600a0b80005121d800001f7a4cd16b41-part1,
testing for partition
nid00035: Can't find SG device /dev/disk/by-id/scsi-3600a0b80005121d800001f7a4cd16b41-part.

It would be nice if either sgpdd-survey or sgpdd-survey.sh would translate aliases to device names.
The attached patch modifies sgpdd-survey to do a 'readlink -f' on the device name if the device
path is something like "/dev/disk/by-*" and the device path is a symbolic link (maybe this is
redundant?).

When we define our devices by-id sgpdd-survey.sh will fail for us without this patch and it will
pass with this patch. Should also work with specifying devices by UUID, etc., but this wasn't
tested.

Comments

Comment by Niu Yawei (Inactive) [ 19/Aug/11 ]

Perform a readlink on the device name if path is /dev/disk/by-id....

Comment by Peter Jones [ 21/Aug/11 ]

fyi, it looks as if a master version of this patch has been contributed under LU515

Comment by Wally Wang (Inactive) [ 24/Aug/11 ]

Please change in:

http://review.whamcloud.com/#change,1284

Comment by Niu Yawei (Inactive) [ 26/Aug/11 ]

dup of ~~LU-515~~.