[LU-6090] DLC: minor cleanup of dlc API code

• Status: Resolved
• Project: Lustre
• Fix Version/s: Lustre 2.8.0
• Type: Bug
• Priority: Minor
• Reporter: Amir Shehata (Inactive)
• Assignee: Amir Shehata (Inactive)
• Resolution: Fixed
• Severity: 3

Description

1. save errno before calling snprintf since that could overwrite errno.

Comments

[Doug Oucharek (Inactive)]

Where is the code in question? Is this the user space library?

[Amir Shehata (Inactive)]

yes in liblnetconfig.c. Reason it's minor is because it will only get reset if there is a problem with the output, which is not likely, but it's good to clean it up, so that we save the errno before calling snprintf, as recommended in: http://linux.die.net/man/3/errno

[Isaac Huang (Inactive)]

To be paranoid, according to the man page: "a function that succeeds is allowed to change errno". I actually saw it happen once with other library functions. It's always a good idea to save errno if it's needed across function calls.

[Gerrit Updater]

Amir Shehata ([e-mail]) uploaded a new patch: http://review.whamcloud.com/15783
Subject: LU-6090 lnet: save errno between function calls
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 5c67a6e1cffbadaa2746941084aa30db66feac4d

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch http://review.whamcloud.com/15783/
Subject: LU-6090 lnet: save errno between function calls
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: f6c886e36d0729b0791e393386e0b4b9c571ce30

[Peter Jones]

Landed for 2.8