[LU-6131] Detect bad commit ids in Lustre-commit: field Created: 16/Jan/15 Updated: 02/Dec/21 Resolved: 02/Dec/21 |
|
| Status: | Resolved |
| Project: | Lustre |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | None |
| Type: | Task | Priority: | Minor |
| Reporter: | Christopher Morrone | Assignee: | Andreas Dilger |
| Resolution: | Won't Fix | Votes: | 0 |
| Labels: | None | ||
| Rank (Obsolete): | 17085 |
| Description |
|
I have found several bad commit ids listed in Lustre-commit: fields in commit messages. Since these are all because we are back-porting commits, the IDs should already exist in the main repository. So perhaps we can get HPDD Checkpatch to validate the commit IDs? |
| Comments |
| Comment by Andreas Dilger [ 17/Jan/15 ] |
|
Chris, this seems reasonable, and should be doable by the script. Do you have specific examples where the commit hash was bad? Presumably they are all on b2_5? In some cases I guess there are commit hashes from the upstream kernel in commit messages going to master, but they should be marked with Linux-commit:. |
| Comment by Christopher Morrone [ 20/Jan/15 ] |
|
Here are a couple: 5748379d28846c672f793ba1f8e143e63531dd05 e5966bdbb7c7644cc04580ad6b4a9006def3f758 |
| Comment by Andreas Dilger [ 02/Dec/21 ] |
|
While it would be possible to warn on a bad commit ID, I don't think it is possible to make this an error, because backporting patches with these commit messages to repositories that don't have the original commit should not fail. |