[LU-618] Reads are not included in IO accounting Created: 23/Aug/11  Updated: 08/Jan/18  Resolved: 17/Dec/17

Status: Resolved
Project: Lustre
Component/s: None
Affects Version/s: Lustre 1.8.7, Lustre 1.8.6
Fix Version/s: Lustre 2.11.0, Lustre 2.10.3

Type: Bug Priority: Minor
Reporter: Mark Hills Assignee: Hongchao Zhang
Resolution: Fixed Votes: 0
Labels: None
Environment:

Linux, Lustre b1_8


Attachments: Text File 0001-IO-Accounting-of-page-reads.patch    
Severity: 3
Bugzilla ID: 24,536
Rank (Obsolete): 9730

 Description   

Writes are accounted for, but not reads. The supplied patch fixes this.

It seems that the accounting it normally done in the kernels page writeback and readahead
functionality. Therefore as Lustre implements its own readahead, it must also maintain its own
accounting on reads (but not writes).

Previously discussed in:



 Comments   
Comment by Peter Jones [ 24/Aug/11 ]

Mark

Could you please upload the patch into gerrit? There are details on how to do this here - http://wiki.whamcloud.com/display/PUB/Using+Gerrit . If this is not clear enough, please let me know.

Thanks

Peter

Comment by Peter Jones [ 27/Oct/11 ]

Hongchao

Please can you take care of porting this patch to master

Thanks

Peter

Comment by Hongchao Zhang [ 01/Nov/11 ]

its patch is tracked at https://review.whamcloud.com/#/c/1636

Comment by Hongchao Zhang [ 22/Nov/11 ]

there is a bug in OFED(1.5.3.2) which causes the patch can't be builded successfully in RHEL5, the detailed info is,

for RHEL5, there is no "task_io_account_cancelled_write" definition prior to 2.6.18-164.2.1 and is okay for OFED, which
defines the same function in the backport (in kernel_addons/backport directory), but the function is defined from
2.6.18-164.2.1, then cause the redefinition error when building Lustre with OFED

Comment by Andreas Dilger [ 26/Feb/14 ]

This conflict with RHEL5 is probably gone, should the patch be refreshed?

Comment by Hongchao Zhang [ 27/Feb/14 ]

the patch has been refreshed

Comment by Hongchao Zhang [ 11/Nov/17 ]

the patch https://review.whamcloud.com/#/c/1636 has been updated against the latest master.

Comment by Gerrit Updater [ 17/Dec/17 ]

Oleg Drokin (oleg.drokin@intel.com) merged in patch https://review.whamcloud.com/1636/
Subject: LU-618 llite: IO accounting of page read
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 48de9b195d71cb57ee50636d75c59d78ee068cee

Comment by Peter Jones [ 17/Dec/17 ]

Landed for 2.11

Comment by Gerrit Updater [ 18/Dec/17 ]

Minh Diep (minh.diep@intel.com) uploaded a new patch: https://review.whamcloud.com/30570
Subject: LU-618 llite: IO accounting of page read
Project: fs/lustre-release
Branch: b2_10
Current Patch Set: 1
Commit: 6f8fb1839bafac7a52dee5779c065fad337d526f

Comment by Gerrit Updater [ 08/Jan/18 ]

John L. Hammond (john.hammond@intel.com) merged in patch https://review.whamcloud.com/30570/
Subject: LU-618 llite: IO accounting of page read
Project: fs/lustre-release
Branch: b2_10
Current Patch Set:
Commit: 19f21a32e74fd347f03c90b33b3d75ee537bf0e7

Generated at Sat Feb 10 01:08:48 UTC 2024 using Jira 9.4.14#940014-sha1:734e6822bbf0d45eff9af51f82432957f73aa32c.