problems with upstream lustre client code (LU-4011)

[LU-6201] remove duplicate fiemap code/defines Created: 03/Feb/15  Updated: 08/Feb/17  Resolved: 28/May/15

Status: Resolved
Project: Lustre
Component/s: None
Affects Version/s: None
Fix Version/s: Lustre 2.8.0

Type: Technical task Priority: Minor
Reporter: Andreas Dilger Assignee: Zhenyu Xu
Resolution: Fixed Votes: 0
Labels: None

Issue Links:
Duplicate
Related
is related to LU-6030 cleanup for ldiskfs patches Resolved
is related to LU-8256 BUG: unable to handle kernel paging r... Resolved
Rank (Obsolete): 17335

 Description   

To remove duplication with newer kernels, including upstream clients, we should remove as much duplication in the fiemap code as possible. It was added in Lustre before it existed in the upstream kernel, and still has some differences that are not landed upstream, so some care is needed.

Most of ll_fiemap.h could be removed:

  • replace struct ll_user_fiemap with struct fiemap in all code (this is already done via #define in ll_fiemap.h)
  • replace struct ll_fiemap_extent with struct fiemap_extent in all code
  • continue to #define fe_device fe_reserved[0] unless we can get the field assignments changed in upstream
  • remove FIEMAP_EXTENT_* constants, except FIEMAP_EXTENT_NET and FIEMAP_EXTENT_NO_DIRECT
  • remove FIEMAP_FLAG_* except FIEMAP_EXTENT_DEVICE_ORDER


 Comments   
Comment by Gerrit Updater [ 03/Feb/15 ]

Bobi Jam (bobijam@hotmail.com) uploaded a new patch: http://review.whamcloud.com/13608
Subject: LU-6201 llite: remove duplicate fiemap defines
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: fb0b4029b004354209d1f6c9cc3d80518917b668

Comment by Gerrit Updater [ 28/May/15 ]

Oleg Drokin (oleg.drokin@intel.com) merged in patch http://review.whamcloud.com/13608/
Subject: LU-6201 llite: remove duplicate fiemap defines
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: c65a2c2a41f4fb9b91f25d4ac073364258691d1b

Comment by Peter Jones [ 28/May/15 ]

Landed for 2.8

Generated at Sat Feb 10 01:58:08 UTC 2024 using Jira 9.4.14#940014-sha1:734e6822bbf0d45eff9af51f82432957f73aa32c.