[LU-6219] Unnecessary usage of O_NONBLOCK flag for archive file by copytool/lhsm_posix Created: 06/Feb/15  Updated: 14/Jun/18  Resolved: 24/Mar/15

Status: Resolved
Project: Lustre
Component/s: None
Affects Version/s: None
Fix Version/s: Lustre 2.8.0

Type: Bug Priority: Minor
Reporter: Bruno Faccini (Inactive) Assignee: Bruno Faccini (Inactive)
Resolution: Fixed Votes: 0
Labels: None

Issue Links:
Related
Severity: 3
Rank (Obsolete): 17395

 Description   

In the first implementations of Posix copytool, file archive/restore was using a loop around select() with handling/retry on EAGAIN.
This was later found as useless for regular files and fixed/changed in patch for LU-3971 (http://review.whamcloud.com/7583, commit 397ebc93cef378e6d77450cdd095e2737b94f2f6).
But the O_NONBLOCK flag usage, during open() of file on archive, has been kept since and must be removed, even if ineffective, to improve code clarity.

 Comments   
Comment by Gerrit Updater [ 06/Feb/15 ]

Faccini Bruno (bruno.faccini@intel.com) uploaded a new patch: http://review.whamcloud.com/13672
Subject: LU-6219 utils: remove O_NONBLOCK usage for archive file
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: b5883d7c41d1a90feaa48f182c8cfc0432957c77

Comment by Bruno Faccini (Inactive) [ 06/Feb/15 ]

Patch to remove the useless usage of O_NONBLOCK flag for archive file is at http://review.whamcloud.com/13672.

Comment by Gerrit Updater [ 18/Mar/15 ]

Oleg Drokin (oleg.drokin@intel.com) merged in patch http://review.whamcloud.com/13672/
Subject: LU-6219 utils: remove O_NONBLOCK usage for archive file
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 24f96966d7c85c1e2ffdaa1be314039a0f5cf422

Generated at Sat Feb 10 01:58:18 UTC 2024 using Jira 9.4.14#940014-sha1:734e6822bbf0d45eff9af51f82432957f73aa32c.