[LU-6221] Posix copytool --dry-run option flawed Created: 06/Feb/15  Updated: 14/Jun/18  Resolved: 06/Apr/15

Status: Resolved
Project: Lustre
Component/s: None
Affects Version/s: None
Fix Version/s: Lustre 2.8.0

Type: Bug Priority: Minor
Reporter: Bruno Faccini (Inactive) Assignee: Bruno Faccini (Inactive)
Resolution: Fixed Votes: 0
Labels: None
Environment:

Any


Issue Links:
Related
Severity: 3
Rank (Obsolete): 17397

 Description   

If the --dry-run option is used, the syntax checking allows --hsm-root to be omitted, which implies that the HSM root won't been dereferenced if doing a dry run. This does not appear to be the case.

In particular, the command:

$ lhsmtool_posix --max-sequence --dry-run /lustre

will segfault. Other instances look like they will have the same problem.

The check in ct_parseopts() that reads:

if (!opt.o_dry_run && opt.o_hsm_root == NULL)

should simply remove the "!opt.dry_run &&" clause. All valid operations require that the hsm root be specified.



 Comments   
Comment by Gerrit Updater [ 06/Feb/15 ]

Faccini Bruno (bruno.faccini@intel.com) uploaded a new patch: http://review.whamcloud.com/13673
Subject: LU-6221 utils: hsm_root is also required for --dry-run
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 5c9cba320168c96918e8e71d1c2f6d54439fb677

Comment by Bruno Faccini (Inactive) [ 06/Feb/15 ]

Master patch is at http://review.whamcloud.com/13673.

Comment by Gerrit Updater [ 26/Mar/15 ]

Oleg Drokin (oleg.drokin@intel.com) merged in patch http://review.whamcloud.com/13673/
Subject: LU-6221 utils: hsm_root is also required for --dry-run
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: adb39ea50c881a9f36d4a9fd2f8693eaec06b5d1

Generated at Sat Feb 10 01:58:19 UTC 2024 using Jira 9.4.14#940014-sha1:734e6822bbf0d45eff9af51f82432957f73aa32c.