[LU-6225] test-framework does not cleanup the env for failed tests Created: 09/Feb/15 Updated: 29/May/17 Resolved: 04/Feb/16 |
|
| Status: | Resolved |
| Project: | Lustre |
| Component/s: | None |
| Affects Version/s: | Lustre 2.5.3, Lustre 2.8.0 |
| Fix Version/s: | Lustre 2.8.0 |
| Type: | Bug | Priority: | Major |
| Reporter: | gaurav mahajan (Inactive) | Assignee: | WC Triage |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Issue Links: |
|
||||||||
| Epic/Theme: | patch, test | ||||||||
| Severity: | 3 | ||||||||
| Project: | Test Infrastructure | ||||||||
| Rank (Obsolete): | 17420 | ||||||||
| Description |
|
if a test fails with an error, we just exit: error() {
error_noexit "$@"
exit 1
}
and therefore the end of run_one() does not execute, what means we do not cleanup the env settings (e.g. fail_loc) before running the next test. |
| Comments |
| Comment by Gerrit Updater [ 09/Feb/15 ] |
|
Gaurav Mahajan (gaurav.mahajan@seagate.com) uploaded a new patch: http://review.whamcloud.com/13689 |
| Comment by Peter Jones [ 09/Feb/15 ] |
|
Does this issue only affect b2_5 or is it relevant for master too? |
| Comment by Gerrit Updater [ 09/Feb/15 ] |
|
Andreas Dilger (andreas.dilger@intel.com) uploaded a new patch: http://review.whamcloud.com/13692 |
| Comment by gaurav mahajan (Inactive) [ 10/Feb/15 ] |
|
The tests which call error_noexit() will return with a value (non zero value) to run_one(). Then run_one() will call error() in case of non zero return value from the test which will again call error_noexit(). If we include reset_fail_loc to error_noexit () then it becomes kind of doing the things which are already done as error() will ultimately get called incase of non zero return value (ie on error) In case of error_and_remount(), agree that it calls error_no_exit() and exits from there. I guess modification is needed for test framework to handle this looping of error() and error_no_exit(). As of now, I will accept the comments and move reset_fail_loc to error_no_exit(). But modifications are needed for test_framework.sh Please leave your comments on this. |
| Comment by Sarah Liu [ 02/Dec/15 ] |
|
Hit in interop testing |
| Comment by Saurabh Tandan (Inactive) [ 16/Dec/15 ] |
|
Server: Master, Build# 3266, Tag 2.7.64 , RHEL 7 |
| Comment by Saurabh Tandan (Inactive) [ 23/Dec/15 ] |
|
Another instance found for : |
| Comment by Saurabh Tandan (Inactive) [ 19/Jan/16 ] |
|
Another Instance for interop: EL7 Server/2.7.1 Client |
| Comment by Saurabh Tandan (Inactive) [ 03/Feb/16 ] |
|
Encountered same issue for tag 2.7.66 for FULL- EL7.1 Server/EL6.7 Client , master , build# 3314 Another failure for master : Tag 2.7.66 FULL - EL7.1 Server/SLES11 SP3 Client, build# 3314 |
| Comment by Gerrit Updater [ 04/Feb/16 ] |
|
Oleg Drokin (oleg.drokin@intel.com) merged in patch http://review.whamcloud.com/13692/ |
| Comment by Joseph Gmitter (Inactive) [ 04/Feb/16 ] |
|
Landed for 2.8 |