[LU-6245] Untangle userland and kernel space support for libcfs Created: 13/Feb/15  Updated: 02/Mar/18  Resolved: 13/Aug/17

Status: Resolved
Project: Lustre
Component/s: None
Affects Version/s: Lustre 2.8.0
Fix Version/s: Lustre 2.11.0

Type: Improvement Priority: Major
Reporter: James A Simmons Assignee: James A Simmons
Resolution: Fixed Votes: 0
Labels: patch

Issue Links:
Blocker
is blocking LU-6401 Untangle lustre userland and kernel h... Resolved
Related
is related to LU-5000 lustre_idl.h compilation regression f... Resolved
is related to LU-6501 nidstrings always true comparisons Resolved
is related to LU-5011 lustre_idl.h again does not compile i... Closed
is related to LU-9679 Prepare lustre for adoption into the ... Resolved
is related to LU-10707 TCP eth routed LNet traffic broken Resolved
is related to LU-8904 pack obd_ioctl_data properly Resolved
Rank (Obsolete): 17491

 Description   

In times past libcfs was built for user space and kernel space. Today we no longer need to build a user land version of libcfs. This ticket will track the work of removing the libcfs abstraction to support both user space and kernel space. In the end we should have a minimal libcfs that only supports kernel space.

 Comments   
Comment by Gerrit Updater [ 13/Feb/15 ]

James Simmons (uja.ornl@gmail.com) uploaded a new patch: http://review.whamcloud.com/13759
Subject: LU-6245 libcfs: remove tcpip abstraction from libcfs
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 81c7924e9b27f2416c19dba5aeeb6d368ae6f79c

Comment by John Hammond [ 13/Feb/15 ]

James,

Of course there are several ways to go about this but in my analysis the next step would be to sort out the LNet headers. Most are not needed for userspace and should be amended to generate an error if _KERNEL_ is not defined. Others like lib-types.h contain a mixture of wire types, definitions needed by kernel and user space, and definitions only needed by kernel space. This header and similar ones "hold on to" some of the libcfs cruft.

Comment by Gerrit Updater [ 13/Feb/15 ]

James Simmons (uja.ornl@gmail.com) uploaded a new patch: http://review.whamcloud.com/13760
Subject: LU-6245 libcfs: remove tcpip abstraction from libcfs
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 2f4a50f14a596a4f7bb86ed19a84cfc421d7a80a

Comment by James A Simmons [ 13/Feb/15 ]

I have some patches that cleanup the LNET headers. The confusing thing with those headers is that user land definitions are located in a couple of headers. We need to talk to the LNET guys to discuss what goes where.

Comment by Gerrit Updater [ 17/Feb/15 ]

James Simmons (uja.ornl@gmail.com) uploaded a new patch: http://review.whamcloud.com/13783
Subject: LU-6245 libcfs: move lucache from libcfs to lustre
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 51427528b599bcbc4f7ec365eecab0dfc1b735f9

Comment by Gerrit Updater [ 18/Feb/15 ]

James Simmons (uja.ornl@gmail.com) uploaded a new patch: http://review.whamcloud.com/13792
Subject: LU-6245 lnet: remove kernel defines in userland headers
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 0a1792b46812ac6c944993d1de7f5da5181f0f7f

Comment by Gerrit Updater [ 18/Feb/15 ]

James Simmons (uja.ornl@gmail.com) uploaded a new patch: http://review.whamcloud.com/13793
Subject: LU-6245 libcfs: cleanup libcfs lock handling
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 1bb798a89148ddd8377291d3976d4c0806a0770c

Comment by Gerrit Updater [ 20/Feb/15 ]

James Simmons (uja.ornl@gmail.com) uploaded a new patch: http://review.whamcloud.com/13835
Subject: LU-6245 libcfs: create userland and kernel string operations
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 2a49e29a102182bde900dbb8a76e2666bca61833

Comment by Gerrit Updater [ 23/Feb/15 ]

James Simmons (uja.ornl@gmail.com) uploaded a new patch: http://review.whamcloud.com/13841
Subject: LU-6245 libcfs: remove mem wrappers for libcfs
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 6d0640de868bf863303c73c5c0816e1e2411f832

Comment by Gerrit Updater [ 25/Feb/15 ]

James Simmons (uja.ornl@gmail.com) uploaded a new patch: http://review.whamcloud.com/13874
Subject: LU-6245 libcfs: remove prim wrappers for libcfs
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 27834b07967580fa9c55aefe3d0f7a2da3d938c1

Comment by Gerrit Updater [ 26/Feb/15 ]

James Simmons (uja.ornl@gmail.com) uploaded a new patch: http://review.whamcloud.com/13899
Subject: LU-6245 libcfs: remove bitops wrappers for libcfs
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: e4faab0020cc3f1face65cac1194d310d9915c6d

Comment by Gerrit Updater [ 27/Feb/15 ]

James Simmons (uja.ornl@gmail.com) uploaded a new patch: http://review.whamcloud.com/13917
Subject: LU-6245 libcfs: remove time wrappers for libcfs
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: b4813e50a58023fd9c3f96c75293fda7b43718c6

Comment by Gerrit Updater [ 25/Mar/15 ]

Oleg Drokin (oleg.drokin@intel.com) merged in patch http://review.whamcloud.com/13760/
Subject: LU-6245 libcfs: remove tcpip abstraction from libcfs
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 0b868add80281c085ce1b297d1cb078deaab802a

Comment by Gerrit Updater [ 25/Mar/15 ]

Oleg Drokin (oleg.drokin@intel.com) merged in patch http://review.whamcloud.com/13783/
Subject: LU-6245 libcfs: move lucache from libcfs to lustre
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: e2e7ea06c66d57ba214cd76e3d19420632aba8dd

Comment by Gerrit Updater [ 25/Mar/15 ]

John L. Hammond (john.hammond@intel.com) uploaded a new patch: http://review.whamcloud.com/14180
Subject: LU-6245 libcfs: remove libcfsutil.h
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 1df4745ab0640465c253264056259d5b6685276f

Comment by Gerrit Updater [ 25/Mar/15 ]

Oleg Drokin (oleg.drokin@intel.com) merged in patch http://review.whamcloud.com/13792/
Subject: LU-6245 lnet: remove kernel defines in userland headers
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: c740130066cf618f4fd31eae716affbb98ecf308

Comment by Gerrit Updater [ 25/Mar/15 ]

Oleg Drokin (oleg.drokin@intel.com) merged in patch http://review.whamcloud.com/13793/
Subject: LU-6245 libcfs: cleanup libcfs lock handling
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 7e95d67f81f1a1a2613809541f30ad4e06618df5

Comment by Gerrit Updater [ 30/Mar/15 ]

frank zago (fzago@cray.com) uploaded a new patch: http://review.whamcloud.com/14270
Subject: LU-6245 utils: split kernel comm between user and kernel
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 83ab3ecd1900f562117712ce7f784813b8e32432

Comment by Gerrit Updater [ 06/Apr/15 ]

Oleg Drokin (oleg.drokin@intel.com) merged in patch http://review.whamcloud.com/13835/
Subject: LU-6245 libcfs: create userland and kernel string operations
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 05d13ca333a3158a98f0c0e048a85564c6b9ed88

Comment by Gerrit Updater [ 20/Apr/15 ]

Oleg Drokin (oleg.drokin@intel.com) merged in patch http://review.whamcloud.com/14270/
Subject: LU-6245 utils: split kernel comm between user and kernel
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: fd44a6d8c71e59ed54b36b2b15e2bdd2b9a74d38

Comment by Gerrit Updater [ 21/Apr/15 ]

James Simmons (uja.ornl@yahoo.com) uploaded a new patch: http://review.whamcloud.com/14512
Subject: LU-6245 lustre: include kthread.h
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: e2f2976d9bf490674b5ab5c216a60beae34ec221

Comment by Gerrit Updater [ 27/Apr/15 ]

James Simmons (uja.ornl@yahoo.com) uploaded a new patch: http://review.whamcloud.com/14624
Subject: LU-6245 libcfs: Sync up libcfs hash code with upstream
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: eff0abe0ba40fae2b8dc694ca3782b1d598c333f

Comment by Gerrit Updater [ 28/Apr/15 ]

Oleg Drokin (oleg.drokin@intel.com) merged in patch http://review.whamcloud.com/14180/
Subject: LU-6245 libcfs: remove libcfsutil.h
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 3b84a1ee5213563945225854a50e9037bb9646db

Comment by Gerrit Updater [ 28/Apr/15 ]

Oleg Drokin (oleg.drokin@intel.com) merged in patch http://review.whamcloud.com/13841/
Subject: LU-6245 libcfs: remove mem wrappers for libcfs
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 6ea4de1b7f237d331c9e0d66f4cc53365d036e5d

Comment by Gerrit Updater [ 28/Apr/15 ]

Oleg Drokin (oleg.drokin@intel.com) merged in patch http://review.whamcloud.com/13874/
Subject: LU-6245 libcfs: remove prim wrappers for libcfs
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: f6995cf04407dff15d6ca79ca44cfa97dc6eb014

Comment by Gerrit Updater [ 28/Apr/15 ]

Oleg Drokin (oleg.drokin@intel.com) merged in patch http://review.whamcloud.com/13899/
Subject: LU-6245 libcfs: remove bitops wrappers for libcfs
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 9e9225acb37dc7e0ceb02c15e4597deab8f25e9a

Comment by Gerrit Updater [ 28/Apr/15 ]

James Simmons (uja.ornl@yahoo.com) uploaded a new patch: http://review.whamcloud.com/14629
Subject: LU-6245 tests: remove libcfs.h from test applications
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 5edf2f85241709e1873016de9e42ce4058b10e9c

Comment by Gerrit Updater [ 07/May/15 ]

Oleg Drokin (oleg.drokin@intel.com) merged in patch http://review.whamcloud.com/14629/
Subject: LU-6245 tests: remove libcfs.h from test applications
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 6ac2f14f0f622863c330b8b96da9373bad1abeb5

Comment by James A Simmons [ 15/May/15 ]

I have started the work on removing the random wrappers. Most of the cleanups are straight forward except for cfs_srand which is used to add to the entropy pool. Now starting in kernel 3.6 we have add_device_randomness which is only missing for RHEL6 kernels. The question is do we even need it. Should we just remove cfs_srand?

Comment by Jian Yu [ 20/May/15 ]

Hi Andreas,
Could you kindly please comment on the question from James? Thank you.

Comment by Gerrit Updater [ 29/May/15 ]

James Simmons (uja.ornl@yahoo.com) uploaded a new patch: http://review.whamcloud.com/15083
Subject: LU-6245 libcfs: move struct netstrfns to nidstr.h
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 0f2fab0dcba0941935c4f4b841627c27739a1abf

Comment by Gerrit Updater [ 30/May/15 ]

James Simmons (uja.ornl@yahoo.com) uploaded a new patch: http://review.whamcloud.com/15085
Subject: LU-6245 libcfs: move cfs_ip_addr_* function from libcfs to LNet
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 5c1427c6cbeced8715f05baf44bfd6bb77da3a5c

Comment by Gerrit Updater [ 30/May/15 ]

James Simmons (uja.ornl@yahoo.com) uploaded a new patch: http://review.whamcloud.com/15086
Subject: LU-6245 lnet: Avoid nodemap related forward declarations in nidstring.c
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: e5a7758074b7807922d8c54968e1b955151d7088

Comment by Gerrit Updater [ 05/Jun/15 ]

Oleg Drokin (oleg.drokin@intel.com) merged in patch http://review.whamcloud.com/15083/
Subject: LU-6245 libcfs: move struct netstrfns to nidstr.h
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: d231bc874075672d3302727e53baef8f4dd03287

Comment by Gerrit Updater [ 10/Jun/15 ]

Oleg Drokin (oleg.drokin@intel.com) merged in patch http://review.whamcloud.com/14624/
Subject: LU-6245 libcfs: cleanup up libcfs hash code for upstream
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: d8278c699434fd7975609e121a1a75820595a601

Comment by Gerrit Updater [ 10/Jun/15 ]

James Simmons (uja.ornl@yahoo.com) uploaded a new patch: http://review.whamcloud.com/15197
Subject: LU-6245 libcfs: remove last of user land code in libcfs module
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 866f45e4f9067c60d8fa14388b1f471bc52a1db5

Comment by Gerrit Updater [ 10/Jun/15 ]

James Simmons (uja.ornl@yahoo.com) uploaded a new patch: http://review.whamcloud.com/15200
Subject: LU-6245 libcfs: cleanup list handling
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 420773df8d5c2dcdb4819a33a4a60a46f02ba00a

Comment by Gerrit Updater [ 10/Jun/15 ]

James Simmons (uja.ornl@yahoo.com) uploaded a new patch: http://review.whamcloud.com/15208
Subject: LU-6245 tests: remove libcfs.h from lctl code
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 7fdcb5c40158c49c2f5c77b6f3a8ef7499ddc7aa

Comment by Gerrit Updater [ 11/Jun/15 ]

James Simmons (uja.ornl@yahoo.com) uploaded a new patch: http://review.whamcloud.com/15217
Subject: LU-6245 utils: remove libcfs.h from lustre utilities code
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 33afb72e4b370f32ccd2f655d7e9637608513b82

Comment by James A Simmons [ 11/Jun/15 ]

The last two patches remove libcfs.h usage from the user land utilities. The libcfs.h header is still left in user land code via the lustre include headers. That will next on the list for cleanup and after that libcfs.h user land code can be removed.

Comment by Andreas Dilger [ 12/Jun/15 ]

James, to answer your question on cfs_rand() and cfs_srand() and cfs_get_random_bytes() - these were very important for the Cray Catamount machine, which had tens of thousands of cores booting simultaneously with a single-threaded interrupt-free kernel. There was not any kind of h/w random number generator to use. That sometimes resulted in the identical random number entropy state across multiple nodes, which would cause problems with e.g. client UUIDs being the same on two clients, as well as lesser issues with initial lustre_handle, and initial XID value and other items that should be unique (if at least for debugging purposes).

The solution was to include the NID into the random number pool, which was one of the very few things that was unique about each node. I think that if it is possible to call add_device_randomness() to include the NID into the entropy pool that would allow us to use the kernel PRNG with some assurance that the number sequences will be different across nodes.

I suspect that for existing RHEL 6 installations that the chance of having the identical state across many nodes is low, most machines have h/w RNG these days via the CPU, and for the few places it matters we can still fold in the NID(s) directly. If the add_device_randomness() API is available with newer kernels then it should be used to include the NID(s) into the RNG pool, to avoid potential problems in the future if a Catamount-like system is revived again.

These "serious" places all use cfs_get_random_bytes(). The cfs_rand() users in lod_qos.c and elsewhere doesn't need this special treatment, and obd_alloc_fail() could be removed entirely (I have an in-progress patch for that, if you want to take it over).

One potential option is to have the RHEL6 add_device_randomness() wrapper hash the input bytes into a 64-bit mask that we can XOR into the values returned by the kernel's get_random_bytes() in cfs_get_random_bytes() (which can be dropped entirely once we drop RHEL6 support). Likewise ll_generate_random_uuid() could also be converted to generate_random_uuid() at that time.

Comment by Gerrit Updater [ 19/Jun/15 ]

Oleg Drokin (oleg.drokin@intel.com) merged in patch http://review.whamcloud.com/15085/
Subject: LU-6245 libcfs: move cfs_ip_addr_* function from kernel libcfs to LNet
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 31114c83e492a1f831165bb2b96496560967b42d

Comment by Gerrit Updater [ 22/Jun/15 ]

James Simmons (uja.ornl@yahoo.com) uploaded a new patch: http://review.whamcloud.com/15368
Subject: LU-6245 gss: remove libcfs.h from gss utilities code
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: e1d230b3fb58498ca8e63b971a824593dd3009f2

Comment by Gerrit Updater [ 08/Jul/15 ]

Oleg Drokin (oleg.drokin@intel.com) merged in patch http://review.whamcloud.com/15086/
Subject: LU-6245 lnet: Avoid nid range related forward declarations in nidstring.c
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: cb611b97b7c43b6d93bc86d4fbde5ba01bb4c8e6

Comment by Gerrit Updater [ 08/Jul/15 ]

Oleg Drokin (oleg.drokin@intel.com) merged in patch http://review.whamcloud.com/15208/
Subject: LU-6245 tests: remove libcfs.h from lctl code
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: a3b9617c740f063a198bd6d81b7860af5799f755

Comment by Gerrit Updater [ 08/Jul/15 ]

Oleg Drokin (oleg.drokin@intel.com) merged in patch http://review.whamcloud.com/15217/
Subject: LU-6245 utils: remove libcfs.h from lustre utilities code
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: a8012629fa66bfeab28b41e23130d020d2367001

Comment by Gerrit Updater [ 10/Jul/15 ]

Oleg Drokin (oleg.drokin@intel.com) merged in patch http://review.whamcloud.com/15368/
Subject: LU-6245 gss: remove libcfs.h from gss utilities code
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 9bcf83c0a84d7cbb86f4bcd55cc01b0ab7c72250

Comment by Doug Oucharek (Inactive) [ 13/Jul/15 ]

James: How is this ticket progressing? With all the patch activity, I'm not sure where it stands.

Doug

Comment by Gerrit Updater [ 19/Jul/15 ]

Oleg Drokin (oleg.drokin@intel.com) merged in patch http://review.whamcloud.com/15197/
Subject: LU-6245 libcfs: remove last of user land code in libcfs module
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: b8e7ad5d6441c48aac6b4a0334735abe9f56ab28

Comment by James A Simmons [ 27/Jul/15 ]

With the landing of the last patch the libcfs module code no longer has any user land code in it. The libcfs headers are left to cleanup.

Comment by Gerrit Updater [ 07/Aug/15 ]

James Simmons (uja.ornl@yahoo.com) uploaded a new patch: http://review.whamcloud.com/15909
Subject: LU-6245 libcfs: remove err.h
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 3f0e9c3ac45bb5879241b72e2af91e8d468bbabb

Comment by Gerrit Updater [ 07/Aug/15 ]

James Simmons (uja.ornl@yahoo.com) uploaded a new patch: http://review.whamcloud.com/15910
Subject: LU-6245 libcfs: remove linux-utils.c
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: d038659f07bfaf194c86434659b188ad489f698f

Comment by Gerrit Updater [ 07/Aug/15 ]

James Simmons (uja.ornl@yahoo.com) uploaded a new patch: http://review.whamcloud.com/15913
Subject: LU-6245 libcfs: remove atomic cpt allocations
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 0e3ce713faed609d4f7d6715ae5219898525fb51

Comment by Gerrit Updater [ 18/Aug/15 ]

Oleg Drokin (oleg.drokin@intel.com) merged in patch http://review.whamcloud.com/13917/
Subject: LU-6245 libcfs: remove unused cfs_timer_done
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 8e91e60a197b8700e1de4043b62aa63112a3eef3

Comment by Gerrit Updater [ 18/Aug/15 ]

Oleg Drokin (oleg.drokin@intel.com) merged in patch http://review.whamcloud.com/15909/
Subject: LU-6245 libcfs: remove err.h
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: a1dabf7958d29cb75e67e1a4ddd1f220f713dceb

Comment by Gerrit Updater [ 18/Aug/15 ]

Oleg Drokin (oleg.drokin@intel.com) merged in patch http://review.whamcloud.com/15913/
Subject: LU-6245 libcfs: remove atomic cpt allocations
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 2de6f02a3e1a4c5f17d4baf3044795453ac52009

Comment by Andreas Dilger [ 25/Aug/15 ]

James, it looks like http://review.whamcloud.com/15910 is the last unlanded patch for this ticket. Are there more cleanup patches needed for this? If yes, can you please file a separate bug for 2.9.0 and we can close this one as fixed for 2.8.0, which simplifies tracking.

Comment by James A Simmons [ 25/Aug/15 ]

Not currently but many more patches are needed. Wouldn't it be better for this ticket to be independent of any version. It is going to be a while before this is finished.

Comment by Gerrit Updater [ 29/Aug/15 ]

Oleg Drokin (oleg.drokin@intel.com) merged in patch http://review.whamcloud.com/15910/
Subject: LU-6245 libcfs: remove linux-utils.c
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 561bd1db8620a3166100b95f25cf10f1b0211e70

Comment by Peter Jones [ 31/Aug/15 ]

I agree with James - removed fix version

Comment by Gerrit Updater [ 19/Oct/15 ]

James Simmons (uja.ornl@yahoo.com) uploaded a new patch: http://review.whamcloud.com/16879
Subject: LU-6245 libcfs: remove types.h from userland code
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 946bd6dc26a28f1f21b657d1725af56ee426f42a

Comment by Gerrit Updater [ 22/Oct/15 ]

James Simmons (uja.ornl@yahoo.com) uploaded a new patch: http://review.whamcloud.com/16914
Subject: LU-6245 libcfs: remove userland headers from libcfs.h
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 160008ed3a36c8b74b7ea66136b11d597b9f0b27

Comment by Gerrit Updater [ 22/Oct/15 ]

James Simmons (uja.ornl@yahoo.com) uploaded a new patch: http://review.whamcloud.com/16916
Subject: LU-6245 libcfs: remove byteorder.h
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 337eb855c27786b30d7c3493578f1d61234bbb03

Comment by Gerrit Updater [ 15/Nov/15 ]

James Simmons (uja.ornl@yahoo.com) uploaded a new patch: http://review.whamcloud.com/17202
Subject: LU-6245 libcfs: remove typedefs in libcfs source code
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: f94e740856388cb6ab3c23d9f9a6c27a61c52b39

Comment by Gerrit Updater [ 27/Nov/15 ]

James Simmons (uja.ornl@yahoo.com) uploaded a new patch: http://review.whamcloud.com/17375
Subject: LU-6245 libcfs: delete some unused code in libcfs
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 61b195190ae25738143fad9e52462ea83cd73482

Comment by Gerrit Updater [ 27/Nov/15 ]

James Simmons (uja.ornl@yahoo.com) uploaded a new patch: http://review.whamcloud.com/17376
Subject: LU-6245 libcfs: remove cfs_fs_time handling
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 531eaa2c776283f876dd73114e3901441479ec7d

Comment by Gerrit Updater [ 16/Dec/15 ]

James Simmons (uja.ornl@yahoo.com) uploaded a new patch: http://review.whamcloud.com/17643
Subject: LU-6245 libcfs: make libcfs_ioctl.h uapi compliant
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 57a6fd6b13a9cdbfe4ca728e0bc5b99662a9f750

Comment by Gerrit Updater [ 02/Feb/16 ]

Oleg Drokin (oleg.drokin@intel.com) merged in patch http://review.whamcloud.com/17643/
Subject: LU-6245 libcfs: make libcfs_ioctl.h and lnetctl.h uapi compliant
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: cf7df5976769bbaa8cab1fc7b8fb80296bfef833

Comment by Gerrit Updater [ 02/Feb/16 ]

Oleg Drokin (oleg.drokin@intel.com) merged in patch http://review.whamcloud.com/16914/
Subject: LU-6245 libcfs: remove userland headers from libcfs.h
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 56782fa6e0cdd208d07480ad4b284ada1f09c60c

Comment by Gerrit Updater [ 14/Mar/16 ]

Oleg Drokin (oleg.drokin@intel.com) merged in patch http://review.whamcloud.com/16879/
Subject: LU-6245 libcfs: remove types.h from userland code
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 4a0ec1d7621cc42e3139d067969e37b8285f7c06

Comment by Gerrit Updater [ 14/Mar/16 ]

Oleg Drokin (oleg.drokin@intel.com) merged in patch http://review.whamcloud.com/17202/
Subject: LU-6245 libcfs: remove typedefs in libcfs source code
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: d40b3f9663c7627f0f08c4e3b5efa6cd206ca0f0

Comment by Gerrit Updater [ 16/Mar/16 ]

James Simmons (uja.ornl@yahoo.com) uploaded a new patch: http://review.whamcloud.com/18964
Subject: LU-6245 libcfs: fix racey module handling
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: a148dad7c59842b72d1fec210b891d1fbdf325f3

Comment by Gerrit Updater [ 23/Mar/16 ]

Oleg Drokin (oleg.drokin@intel.com) merged in patch http://review.whamcloud.com/17376/
Subject: LU-6245 libcfs: remove cfs_fs_time handling
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: c3ddfae1b795385aa14db61df1a416ab57bfc066

Comment by Gerrit Updater [ 23/Mar/16 ]

Oleg Drokin (oleg.drokin@intel.com) uploaded a new patch: http://review.whamcloud.com/19094
Subject: Revert "LU-6245 libcfs: remove cfs_fs_time handling"
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 77f3810c080cdea09e64108d9aa812d53a29eaf9

Comment by James A Simmons [ 23/Mar/16 ]

Patch 17376 was done before RHEL7 picked up the time64_t changes in later kernels. That API is now in the latest RHEL7 kernels which caused the breakage we are seeing.

Comment by Gerrit Updater [ 23/Mar/16 ]

Oleg Drokin (oleg.drokin@intel.com) merged in patch http://review.whamcloud.com/19094/
Subject: Revert "LU-6245 libcfs: remove cfs_fs_time handling"
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: c8e9c0cdd3f82385f5f088b61f677e62f063517f

Comment by Gerrit Updater [ 23/Mar/16 ]

James Simmons (uja.ornl@yahoo.com) uploaded a new patch: http://review.whamcloud.com/19113
Subject: LU-6245 libcfs: remove libcfs userland time abstraction
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: e5bdc857dff4b158def5c9b51a167115d7dbbf94

Comment by Gerrit Updater [ 06/Apr/16 ]

Oleg Drokin (oleg.drokin@intel.com) merged in patch http://review.whamcloud.com/18964/
Subject: LU-6245 libcfs: fix racey module handling
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 42cb962d3f15f827be739ac5d02692d2643c3e07

Comment by Gerrit Updater [ 07/Apr/16 ]

James Simmons (uja.ornl@yahoo.com) uploaded a new patch: http://review.whamcloud.com/19383
Subject: LU-6245 libcfs: Remove kp30.h
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 739742b9c9c294493f29b217c25156f7ca2738d6

Comment by Gerrit Updater [ 11/Apr/16 ]

Oleg Drokin (oleg.drokin@intel.com) merged in patch http://review.whamcloud.com/19113/
Subject: LU-6245 libcfs: remove libcfs userland time abstraction
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 8caff5d019674aea7d98e225d0136bf4694d5157

Comment by Gerrit Updater [ 11/Apr/16 ]

James Simmons (uja.ornl@yahoo.com) uploaded a new patch: http://review.whamcloud.com/19459
Subject: LU-6245 libcfs: remove sysctl module handling
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: b5bd09da04e5b110c6444560a51422e211fa113d

Comment by Gerrit Updater [ 11/Apr/16 ]

James Simmons (uja.ornl@yahoo.com) uploaded a new patch: http://review.whamcloud.com/19460
Subject: LU-6245 libcfs: Remove kp30.h
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: bf755ecc66c58d0c6691caabf6030579465ea1a1

Comment by Gerrit Updater [ 21/Apr/16 ]

Oleg Drokin (oleg.drokin@intel.com) merged in patch http://review.whamcloud.com/19383/
Subject: LU-6245 libcfs: replace CFS_MODULE_PARAM with linux kernel module api
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: d96a9248708d4da02728c9976a9a90ba29bd2bc0

Comment by Gerrit Updater [ 04/May/16 ]

Oleg Drokin (oleg.drokin@intel.com) merged in patch http://review.whamcloud.com/19459/
Subject: LU-6245 libcfs: remove sysctl module handling
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 9766f8e746731c74096c86fcc9514c3e3219e674

Comment by Gerrit Updater [ 04/May/16 ]

Oleg Drokin (oleg.drokin@intel.com) merged in patch http://review.whamcloud.com/19460/
Subject: LU-6245 libcfs: Remove kp30.h
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: b8bddf048483d3ed95201de06f2da0925c82cd54

Comment by Gerrit Updater [ 13/May/16 ]

James Simmons (uja.ornl@yahoo.com) uploaded a new patch: http://review.whamcloud.com/20204
Subject: LU-6245 libcfs: remove types abstraction from kernel code
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 006f47fbd02ede01d43f5c7b4ab55a3b78260e6d

Comment by Gerrit Updater [ 02/Jun/16 ]

James Simmons (uja.ornl@yahoo.com) uploaded a new patch: http://review.whamcloud.com/20590
Subject: LU-6245 client: remove types abstraction from client code
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: be56a6f5d75d84b173c0cf8e8ac2297bb0ea2816

Comment by Gerrit Updater [ 14/Jun/16 ]

Oleg Drokin (oleg.drokin@intel.com) merged in patch http://review.whamcloud.com/20204/
Subject: LU-6245 libcfs: remove types abstraction from libcfs/LNet code
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 2b8c4566a6a63cdf09e555a744ce6a1453651b98

Comment by Gerrit Updater [ 07/Jul/16 ]

James Simmons (uja.ornl@yahoo.com) uploaded a new patch: http://review.whamcloud.com/21187
Subject: LU-6245 server: remove types abstraction from server code
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 93cddebe2466c6dc2a9595feb1816ab005ef847c

Comment by Gerrit Updater [ 22/Aug/16 ]

Oleg Drokin (oleg.drokin@intel.com) merged in patch http://review.whamcloud.com/20590/
Subject: LU-6245 client: remove types abstraction from client code
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 500f334631c6ebec72f5791472f21603da3e0ef9

Comment by Gerrit Updater [ 25/Aug/16 ]

James Simmons (uja.ornl@yahoo.com) uploaded a new patch: http://review.whamcloud.com/22138
Subject: LU-6245 libcfs: use libcfs_private.h only for kernel space
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: b0a2501d6bcb98eab17ade7751bfbced500e7d5a

Comment by Gerrit Updater [ 25/Aug/16 ]

James Simmons (uja.ornl@yahoo.com) uploaded a new patch: http://review.whamcloud.com/22139
Subject: LU-6245 libcfs: move uid handling to linux directory
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 8929f66a11e8decec27dcd3ed1e45a493058ec2f

Comment by Gerrit Updater [ 02/Sep/16 ]

Oleg Drokin (oleg.drokin@intel.com) merged in patch http://review.whamcloud.com/15200/
Subject: LU-6245 libcfs: cleanup list handling
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 91ef75669c7e41091378a8401ca0c093b7f17174

Comment by Gerrit Updater [ 02/Sep/16 ]

Oleg Drokin (oleg.drokin@intel.com) merged in patch http://review.whamcloud.com/22139/
Subject: LU-6245 libcfs: move uid handling to linux directory
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 74cecb5aad2243d1173405dc0063f4b46396f92f

Comment by Gerrit Updater [ 07/Sep/16 ]

James Simmons (uja.ornl@yahoo.com) uploaded a new patch: http://review.whamcloud.com/22370
Subject: LU-6245 server: remove types abstraction from lfsck and OSS code
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 0f1ca20ddba2efde7c97a81160bdcb77a69b17e8

Comment by Gerrit Updater [ 07/Sep/16 ]

James Simmons (uja.ornl@yahoo.com) uploaded a new patch: http://review.whamcloud.com/22371
Subject: LU-6245 server: remove types abstraction from MDS/MGS code
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 6df9e57abf89df139b04e4eed7efb7f2d1145e07

Comment by Gerrit Updater [ 22/Sep/16 ]

Oleg Drokin (oleg.drokin@intel.com) merged in patch http://review.whamcloud.com/22370/
Subject: LU-6245 server: remove types abstraction from lfsck and OSS code
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 520631764c0e9d1bf5c70f8d060b81a2f322d5dc

Comment by Gerrit Updater [ 22/Sep/16 ]

Oleg Drokin (oleg.drokin@intel.com) merged in patch http://review.whamcloud.com/22371/
Subject: LU-6245 server: remove types abstraction from MDS/MGS code
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 86e61f80cf6921b537a465b2f6b28914eaac8168

Comment by Gerrit Updater [ 26/Sep/16 ]

Oleg Drokin (oleg.drokin@intel.com) merged in patch http://review.whamcloud.com/16916/
Subject: LU-6245 libcfs: remove byteorder.h
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: e8965be4e135b55f0a900446e4a1c74905eaccd1

Comment by Gerrit Updater [ 26/Sep/16 ]

Oleg Drokin (oleg.drokin@intel.com) merged in patch http://review.whamcloud.com/21187/
Subject: LU-6245 server: remove types abstraction from quota/target/nodemap code
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 676c2fe47c8de0825db3001f1e964347be3dc479

Comment by Gerrit Updater [ 26/Sep/16 ]

James Simmons (uja.ornl@yahoo.com) uploaded a new patch: http://review.whamcloud.com/22732
Subject: LU-6245 libcfs: remove last of types abstractions
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: f24f93e86f5c20d5475d8fb23f8040bc329c055e

Comment by Gerrit Updater [ 30/Sep/16 ]

James Simmons (uja.ornl@yahoo.com) uploaded a new patch: http://review.whamcloud.com/22857
Subject: LU-6245 libcfs: remove cfs_fs_time handling
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: c79aec76c42cb1da4fdcd576e039fbd21f2d9435

Comment by Gerrit Updater [ 01/Oct/16 ]

James Simmons (uja.ornl@yahoo.com) uploaded a new patch: http://review.whamcloud.com/22866
Subject: LU-6245 libcfs: add ktime_get_real_seconds support
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 61400a14e7c2032a805efdfd8e8623f8eed10d76

Comment by Gerrit Updater [ 08/Oct/16 ]

Oleg Drokin (oleg.drokin@intel.com) merged in patch http://review.whamcloud.com/22732/
Subject: LU-6245 libcfs: remove last of types abstractions
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 4f4622c417429053bad7943da02b1965ae178a37

Comment by Gerrit Updater [ 08/Oct/16 ]

Oleg Drokin (oleg.drokin@intel.com) merged in patch http://review.whamcloud.com/22857/
Subject: LU-6245 libcfs: remove cfs_fs_time handling
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: c6ed413f09efa7776ea78c7010cb2e71f8c966b3

Comment by Gerrit Updater [ 12/Nov/16 ]

James Simmons (uja.ornl@yahoo.com) uploaded a new patch: http://review.whamcloud.com/23733
Subject: LU-6245 libcfs: remove wrappers for timer functions
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: fb75d58e5ed00d25e63ed1de7a37e85d2b7e87d2

Comment by Gerrit Updater [ 01/Jan/17 ]

Oleg Drokin (oleg.drokin@intel.com) merged in patch https://review.whamcloud.com/22866/
Subject: LU-6245 libcfs: add ktime_get_real_seconds support
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 07ff616a18cc602460724e6693e142782cad0fcc

Comment by Gerrit Updater [ 02/Jan/17 ]

James Simmons (uja.ornl@yahoo.com) uploaded a new patch: https://review.whamcloud.com/24575
Subject: LU-6245 libcfs: replace IS_PO2 with is_power_of_2 in server code
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 2751e6b8954dc2e0150c9927d4f497dd9d0dcee5

Comment by Gerrit Updater [ 24/Jan/17 ]

Oleg Drokin (oleg.drokin@intel.com) merged in patch https://review.whamcloud.com/23733/
Subject: LU-6245 libcfs: remove wrappers for timer functions
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 5801dad47e4727a44b6343a3f7f875d7992f29a3

Comment by Gerrit Updater [ 31/Jan/17 ]

Oleg Drokin (oleg.drokin@intel.com) merged in patch https://review.whamcloud.com/22138/
Subject: LU-6245 libcfs: use libcfs_private.h only for kernel space
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: f431777cf5cbb0f1493e91a35bbc2a26e1d14db9

Comment by Gerrit Updater [ 07/Feb/17 ]

Oleg Drokin (oleg.drokin@intel.com) merged in patch https://review.whamcloud.com/24575/
Subject: LU-6245 libcfs: replace IS_PO2 with is_power_of_2 in server code
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: fc117cc92d224466c1ec45de422f9f6624bbb1da

Comment by Gerrit Updater [ 18/Jul/17 ]

James Simmons (uja.ornl@yahoo.com) uploaded a new patch: https://review.whamcloud.com/28089
Subject: LU-6245 uapi: move libcfs/lnet UAPI header into own uapi directory
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: b5d9cfa6508d6f65897690c8409155c827285155

Comment by Gerrit Updater [ 05/Aug/17 ]

Oleg Drokin (oleg.drokin@intel.com) merged in patch https://review.whamcloud.com/28089/
Subject: LU-6245 uapi: move libcfs/lnet UAPI header into own uapi directory
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: d92bd22523aa9bb1cdb91ded3d46fb180f68a93c

Comment by James A Simmons [ 05/Aug/17 ]

I have just one patch left that I will submit shortly. Then this work will finish!!!

Comment by James A Simmons [ 07/Aug/17 ]

The only work left is the test application it_test.c pulling in interval_tree.c from the lustre kernel source. This shouldn't be happening so I was looking at implementing the functions from interval_tree.c that is needed for it_test. Now when I looked to see how to test these changes I noticed it_test isn' even used anywere!!! Is it
safe to delete it if this is the case?

Comment by Gerrit Updater [ 07/Aug/17 ]

James Simmons (uja.ornl@yahoo.com) uploaded a new patch: https://review.whamcloud.com/28406
Subject: LU-6245 tests: remove it_test
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: d7622179968c6fedb9019c2d55a5bea18533b95f

Comment by James A Simmons [ 07/Aug/17 ]

Last patch for this ticket push!!!!

Comment by Gerrit Updater [ 13/Aug/17 ]

Oleg Drokin (oleg.drokin@intel.com) merged in patch https://review.whamcloud.com/28406/
Subject: LU-6245 tests: remove it_test
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: ebd0885c544dfec44c303361222decb9fe3d82d2

Comment by James A Simmons [ 13/Aug/17 ]

After 5 years and 10K+ lines of code changes this project is over.

Generated at Sat Feb 10 01:58:32 UTC 2024 using Jira 9.4.14#940014-sha1:734e6822bbf0d45eff9af51f82432957f73aa32c.