[LU-6266] kstrtoul does not exist before 2.6.39

• Status: Resolved
• Project: Lustre
• Affects Version/s: Lustre 2.7.0, Lustre 2.5.4
• Fix Version/s: Lustre 2.8.0, Lustre 2.5.4
• Type: Bug
• Priority: Minor
• Reporter: Andreas Dilger
• Assignee: Andreas Dilger
• Resolution: Fixed
• Severity: 3

Description

The kstrtoul() function was only added to the upstream kernel in 2.6.39 (commit v2.6.38-6934-g33ee3b2). While it is backported to RHEL6 2.6.32 kernels, it does not exist for vanilla kernels before that point.

The patch from http://review.whamcloud.com/5700 "LU-1778 llite: fix inconsistencies of root squash feature" added uses of kstrtoul() to Lustre that break the build for older kernels. While it would be possible to convert those calls over to simple_strtoul() that function is deprecated in newer kernels, and checkpatch.pl will generate a warning, so using kstrtoul() is the right thing for newer kernels.

Comments

[Gerrit Updater]

Andreas Dilger ([e-mail]) uploaded a new patch: http://review.whamcloud.com/13820
Subject: LU-6266 libcfs: add kstrtoul() compat function
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 7152817e70b605dd5ecf03e6eb90e895a8cb8055

[Gerrit Updater]

Andreas Dilger ([e-mail]) uploaded a new patch: http://review.whamcloud.com/13821
Subject: LU-6266 libcfs: add kstrtoul() compat function
Project: fs/lustre-release
Branch: b2_5
Current Patch Set: 1
Commit: 66cc169998700168741c4443d1ea683e20643a29

[James A Simmons]

Should we drop support for pathless clients with kernel versions 2.6.38 and less? It might be time for some cleanup for support there.

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch http://review.whamcloud.com/13820/
Subject: LU-6266 libcfs: add kstrtoul() compat function
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 6804cf756791d0e8342f209f2daf445100509b22

[Peter Jones]

Landed for 2.8