[LU-629] _debug_req() never prints out opcode/flags/status

• Status: Resolved
• Project: Lustre
• Affects Version/s: Lustre 2.1.0
• Fix Version/s: Lustre 2.2.0, Lustre 2.1.2
• Type: Bug
• Priority: Major
• Reporter: Andreas Dilger
• Assignee: Andreas Dilger
• Resolution: Fixed
• Severity: 3
• Bugzilla ID: 16,359

Description

The 2.x _debug_req() function was changed in https://bugzilla.lustre.org/show_bug.cgi?id=16359 (commit 5467a860213d454759bdfad91503691d6692b317) to avoid problems with accessing unswabbed message buffers. Unfortunately, this broke the printing of many useful _debug_req() messages, because it didn't check whether swabbing was actually needed in the first place.

Also, in ptlrpc_expire_one_request() some extra debugging information was added in commit 368689640e6a42a152eee73d354dd6f68836065b, but never removed, making this common message overly verbose.

Comments

[Andreas Dilger]

Example on server:
LustreError: 19399:0:(ldlm_lib.c:2130:target_send_reply_msg()) @@@ dropping reply req@ffff880037161050 x1378023469219904/t4294967299(0) o-1->e434d9e8-77da-5750-e457-621ba115eb10@NET_0x200000a0a0468_UUID:0/0 lens 456/416 e 0 to 0 dl 1314185702 ref 1 fl Interpret:/ffffffff/ffffffff rc 0/-1

Example on client:
Lustre: 30376:0:(client.c:1778:ptlrpc_expire_one_request()) @@@ Request x1378023469219874 sent from lustre-MDT0000-mdc-ffff880079da9c00 to NID 10.10.4.106@tcp has timed out for slow reply: [sent 1314185684] [real_sent 1314185684] [current 1314185696] [deadline 12s] [delay 0s] req@ffff88007740ec00 x1378023469219874/t0(0) o-1->lustre-MDT0000_UUID@10.10.4.106@tcp:30/10 lens 232/216 e 0 to 1 dl 1314185696 ref 2 fl Rpc:X/ffffffff/ffffffff rc 0/-1

Patch submitted as http://review.whamcloud.com/1286

[Build Master (Inactive)]

Integrated in lustre-master » x86_64,client,el5,ofa #313
LU-629 ptlrpc: fix _debug_req to print opc/status

Oleg Drokin : e4943206b31f8132ad5a8ea6650905c59cd13aea
Files :

• lustre/ptlrpc/pack_generic.c
• libcfs/libcfs/nidstrings.c
• lustre/ptlrpc/client.c

[Build Master (Inactive)]

Integrated in lustre-master » i686,client,el6,inkernel #313
LU-629 ptlrpc: fix _debug_req to print opc/status

Oleg Drokin : e4943206b31f8132ad5a8ea6650905c59cd13aea
Files :

• lustre/ptlrpc/client.c
• lustre/ptlrpc/pack_generic.c
• libcfs/libcfs/nidstrings.c

[Build Master (Inactive)]

Integrated in lustre-master » x86_64,client,el5,inkernel #313
LU-629 ptlrpc: fix _debug_req to print opc/status

Oleg Drokin : e4943206b31f8132ad5a8ea6650905c59cd13aea
Files :

• libcfs/libcfs/nidstrings.c
• lustre/ptlrpc/pack_generic.c
• lustre/ptlrpc/client.c

[Build Master (Inactive)]

Integrated in lustre-master » x86_64,server,el6,inkernel #313
LU-629 ptlrpc: fix _debug_req to print opc/status

Oleg Drokin : e4943206b31f8132ad5a8ea6650905c59cd13aea
Files :

• libcfs/libcfs/nidstrings.c
• lustre/ptlrpc/pack_generic.c
• lustre/ptlrpc/client.c

[Build Master (Inactive)]

Integrated in lustre-master » x86_64,client,el6,inkernel #313
LU-629 ptlrpc: fix _debug_req to print opc/status

Oleg Drokin : e4943206b31f8132ad5a8ea6650905c59cd13aea
Files :

• lustre/ptlrpc/pack_generic.c
• libcfs/libcfs/nidstrings.c
• lustre/ptlrpc/client.c

[Build Master (Inactive)]

Integrated in lustre-master » x86_64,server,el5,ofa #313
LU-629 ptlrpc: fix _debug_req to print opc/status

Oleg Drokin : e4943206b31f8132ad5a8ea6650905c59cd13aea
Files :

• lustre/ptlrpc/pack_generic.c
• libcfs/libcfs/nidstrings.c
• lustre/ptlrpc/client.c

[Build Master (Inactive)]

Integrated in lustre-master » x86_64,server,el5,inkernel #313
LU-629 ptlrpc: fix _debug_req to print opc/status

Oleg Drokin : e4943206b31f8132ad5a8ea6650905c59cd13aea
Files :

• lustre/ptlrpc/pack_generic.c
• libcfs/libcfs/nidstrings.c
• lustre/ptlrpc/client.c

[Build Master (Inactive)]

Integrated in lustre-master » x86_64,client,sles11,inkernel #313
LU-629 ptlrpc: fix _debug_req to print opc/status

Oleg Drokin : e4943206b31f8132ad5a8ea6650905c59cd13aea
Files :

• lustre/ptlrpc/pack_generic.c
• lustre/ptlrpc/client.c
• libcfs/libcfs/nidstrings.c

[Build Master (Inactive)]

Integrated in lustre-master » i686,server,el6,inkernel #313
LU-629 ptlrpc: fix _debug_req to print opc/status

Oleg Drokin : e4943206b31f8132ad5a8ea6650905c59cd13aea
Files :

• libcfs/libcfs/nidstrings.c
• lustre/ptlrpc/client.c
• lustre/ptlrpc/pack_generic.c

[Build Master (Inactive)]

Integrated in lustre-master » x86_64,client,ubuntu1004,inkernel #313
LU-629 ptlrpc: fix _debug_req to print opc/status

Oleg Drokin : e4943206b31f8132ad5a8ea6650905c59cd13aea
Files :

• libcfs/libcfs/nidstrings.c
• lustre/ptlrpc/pack_generic.c
• lustre/ptlrpc/client.c

[Build Master (Inactive)]

Integrated in lustre-master » i686,client,el5,ofa #313
LU-629 ptlrpc: fix _debug_req to print opc/status

Oleg Drokin : e4943206b31f8132ad5a8ea6650905c59cd13aea
Files :

• lustre/ptlrpc/pack_generic.c
• lustre/ptlrpc/client.c
• libcfs/libcfs/nidstrings.c

[Build Master (Inactive)]

Integrated in lustre-master » i686,server,el5,ofa #313
LU-629 ptlrpc: fix _debug_req to print opc/status

Oleg Drokin : e4943206b31f8132ad5a8ea6650905c59cd13aea
Files :

• lustre/ptlrpc/pack_generic.c
• lustre/ptlrpc/client.c
• libcfs/libcfs/nidstrings.c

[Build Master (Inactive)]

Integrated in lustre-master » i686,server,el5,inkernel #313
LU-629 ptlrpc: fix _debug_req to print opc/status

Oleg Drokin : e4943206b31f8132ad5a8ea6650905c59cd13aea
Files :

• libcfs/libcfs/nidstrings.c
• lustre/ptlrpc/pack_generic.c
• lustre/ptlrpc/client.c

[Build Master (Inactive)]

Integrated in lustre-master » i686,client,el5,inkernel #313
LU-629 ptlrpc: fix _debug_req to print opc/status

Oleg Drokin : e4943206b31f8132ad5a8ea6650905c59cd13aea
Files :

• libcfs/libcfs/nidstrings.c
• lustre/ptlrpc/client.c
• lustre/ptlrpc/pack_generic.c

[Andreas Dilger]

landed